Skip to content

Web: Fix crash that happens when the app receives an unknown message #15087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laurent22 wants to merge 2 commits into
base: dev
Choose a base branch
from
+17 −2
Open

Web: Fix crash that happens when the app receives an unknown message #15087

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b5111d
update
laurent22 Apr 13, 2026
0b7e43c
update
laurent22 Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions packages/app-mobile/utils/ipc/RNToWebViewMessenger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ import { WebViewControl } from '../../components/ExtendedWebView/types';
import { RefObject } from 'react';
import { OnMessageEvent } from '../../components/ExtendedWebView/types';
import { Platform } from 'react-native';
import Logger from '@joplin/utils/Logger';

const logger = Logger.create('RNToWebViewMessenger');

const canUseOptimizedPostMessage = Platform.OS === 'web';

Expand Down Expand Up @@ -41,10 +44,22 @@ export default class RNToWebViewMessenger<LocalInterface, RemoteInterface> exten

public onWebViewMessage = (event: OnMessageEvent) => {
if (!this.hasBeenClosed()) {
let data;
if (canUseOptimizedPostMessage) {
void this.onMessage(event.nativeEvent.data);
data = event.nativeEvent.data;
} else {
try {
data = JSON.parse(event.nativeEvent.data);
} catch {
logger.warn('Failed to parse message:', event.nativeEvent.data);
return;
}
}

if (typeof data === 'object' && data !== null && typeof data.kind === 'string') {
void this.onMessage(data);
} else {
void this.onMessage(JSON.parse(event.nativeEvent.data));
logger.info('Unknown message format:', event.nativeEvent.data);
}
}
};
Expand Down
Loading