Skip to content

Mobile: Fix #15104: Truncate verbose decryption error payloads in Status screen #15112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ehtesham-Zahid wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Mobile: Fix #15104: Truncate verbose decryption error payloads in Status screen #15112

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e1167f
Mobile: Fix #15104: Truncate verbose decryption error payloads in Sta…
Ehtesham-Zahid Apr 15, 2026
f0bb653
Mobile: Fix #15104: Use localized string for decryption error detection
Ehtesham-Zahid Apr 15, 2026
5c93bd5
Mobile: Fixes #15104: Simplify status screen truncation using numberO…
Ehtesham-Zahid Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions packages/app-mobile/components/screens/status.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ interface State {
interface ProcessedLine {
key: string;
text?: string;
sectionName?: string;
isSection?: boolean;
isDivider?: boolean;
retryAllHandler?: ()=> void;
Expand All @@ -45,9 +46,9 @@ const processReport = (report: ReportSection[], refreshScreen: OnRefreshScreen,
let style: TextStyle = { ...baseStyle };
style.fontWeight = 'bold';
if (i > 0) style.paddingTop = 20;
lines.push({ key: `section_${i}`, isSection: true, text: section.title });
lines.push({ key: `section_${i}`, isSection: true, text: section.title, sectionName: section.name });
if (section.canRetryAll) {
lines.push({ key: `retry_all_${i}`, text: '', retryAllHandler: section.retryAllHandler });
lines.push({ key: `retry_all_${i}`, text: '', retryAllHandler: section.retryAllHandler, sectionName: section.name });
}

for (const n in section.body) {
Expand Down Expand Up @@ -76,15 +77,15 @@ const processReport = (report: ReportSection[], refreshScreen: OnRefreshScreen,
if (item.type === ReportItemType.OpenList) {
currentList = [];
} else if (item.type === ReportItemType.CloseList) {
lines.push({ key: `list_${i}_${n}`, listItems: currentList });
lines.push({ key: `list_${i}_${n}`, listItems: currentList, sectionName: section.name });
currentList = null;
}
text = item.text;
} else {
text = item;
}

const line = { key: `item_${i}_${n}`, text: text, retryHandler, ignoreHandler };
const line = { key: `item_${i}_${n}`, text: text, retryHandler, ignoreHandler, sectionName: section.name };
if (currentList) {
// The OpenList item, for example, might be empty and should be skipped:
const hasContent = line.text || retryHandler || ignoreHandler;
Expand All @@ -96,7 +97,7 @@ const processReport = (report: ReportSection[], refreshScreen: OnRefreshScreen,
}
}

lines.push({ key: `divider2_${i}`, isDivider: true });
lines.push({ key: `divider2_${i}`, isDivider: true, sectionName: section.name });
}

return lines;
Expand Down Expand Up @@ -204,7 +205,9 @@ class StatusScreenComponent extends BaseScreenComponent<Props, State> {
</View>
) : null;

const textComponent = text ? <Text style={style} role={textRole}>{text}</Text> : null;
const localizedItemsWithErrorPrefix = _('Items with error: %s', '');
const isFailedDecryptionErrorHeader = item.sectionName === 'failedDecryption' && text?.startsWith(localizedItemsWithErrorPrefix);
const textComponent = text ? <Text style={style} role={textRole} numberOfLines={isFailedDecryptionErrorHeader ? 2 : undefined} ellipsizeMode={isFailedDecryptionErrorHeader ? 'tail' : undefined}>{text}</Text> : null;
Comment thread
Ehtesham-Zahid marked this conversation as resolved.
Outdated
if (item.isDivider) {
return <View style={styles.divider} role='separator' key={item.key} />;
} else if (item.listItems) {
Expand Down
Loading