Android: Fixes #14548: Accessibility: Fix tab ordering in the note viewer screen

[personalizedrefrigerator]

Problem

Pressing tab with focus on the note title did not move focus to the note body. Instead, focus cycled through other focusable buttons in the app. This is a regression from the v3.5 release.

Note: #14548 affects external keyboard focus, but does not seem to affect screen reader focus.

Solution

This pull request implements a workaround: The note title input row is marked as focusable. This fixes the focus order issue reported in #14548, but makes the title container focusable, adding a new View to the focus order.

Fixes #14548.

Note

This change is currently only applied on Android: At least in an iOS simulator, the tab key inserts a tab character, rather than moves focus. Since I'm unsure whether #14548 affects hardware iOS devices and the workaround adds an extra view to the focus order, the change is currently Android-specific

Testing

Web (regression testing)

Tab focus continues to visit the note title and completion checkbox:

web-tab-focus.mov

iOS (regression testing)

With VoiceOver enabled, focus can visit the note title and completion checkbox.

Edit: Removed iOS screen recording: The VoiceOver focus indicator and output were not captured by the recording.

Android

Moving focus from the title input to the note body, then to the checkbox input:

android-notalkback.mov

Moving TalkBack focus from the title input to the note body, then back to the title input:

android-talkback.mov