Skip to content

Desktop: Fixes #15189: Fix Rich Text Editor fails to load in secondary windows#15190

Open
personalizedrefrigerator wants to merge 3 commits intolaurent22:devfrom
personalizedrefrigerator:pr/desktop/fix-rte-in-secondary-windows
Open

Desktop: Fixes #15189: Fix Rich Text Editor fails to load in secondary windows#15190
personalizedrefrigerator wants to merge 3 commits intolaurent22:devfrom
personalizedrefrigerator:pr/desktop/fix-rte-in-secondary-windows

Conversation

@personalizedrefrigerator
Copy link
Copy Markdown
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Apr 23, 2026

Problem

#15035 removed a deprecated document.write call to fix a hang when closing secondary windows. The document.write call, however, was required to prevent the secondary window from opening in compatibility mode (TinyMCE does not support compatibility mode).

Solution

To fix the Rich Text Editor regression: Revert #15035.

To try to prevent #14968 from returning:

  1. Add try/catch guards that may prevent the secondary window crash/hang from occurring.
    • Note: The try/catch do fix an error overlay related to adding/removing context menu listeners observed while testing this pull request locally.
  2. Set nodeIntegration: false when opening secondary windows: it doesn't need to be true (this was another potential crash/hang workaround I was looking into before creating Desktop: Resolves #14968: Fix freeze/crash when rapidly closing secondary windows #15035).

Testing

Fedora 43/Linux:

  1. Open 20 secondary windows.
  2. Close them all rapidly.
  3. Verify that the app doesn't crash.
  4. Repeat steps 1-3 for the Rich Text Editor.
Screencast.from.2026-04-23.16-15-02.webm

@coderabbitai coderabbitai Bot added bug It's a bug desktop All desktop platforms editor labels Apr 23, 2026
coderabbitai[bot]

This comment was marked as off-topic.

@github-actions github-actions Bot deleted a comment from coderabbitai Bot Apr 23, 2026
@github-actions github-actions Bot deleted a comment from coderabbitai Bot Apr 23, 2026
@mrjo118
Copy link
Copy Markdown
Contributor

mrjo118 commented Apr 24, 2026

I will give this a test to see whether I can produce a crash with this alternate fix

@mrjo118
Copy link
Copy Markdown
Contributor

mrjo118 commented Apr 25, 2026

I can't produce any crashes on Windows 10. Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug It's a bug desktop All desktop platforms editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants