Doc: Add a Joplin Cloud plan with more available storage to the website#15504
Draft
personalizedrefrigerator wants to merge 2 commits into
Draft
Conversation
| <p> | ||
| <i class="fas fa-check feature feature-on"></i>{{label}} | ||
| {{#actions}} | ||
| <button type="button" class="action-link action-{{actionId}}">→ <span class="action-label">{{label}}</span></button> |
Contributor
There was a problem hiding this comment.
Mark the decorative arrow as aria-hidden.
The → is purely decorative; screen readers will announce it as "right arrow" before the action label, which is noisy. Wrap it (or add aria-hidden) so only the action label is announced.
♿ Proposed fix
- <button type="button" class="action-link action-{{actionId}}">→ <span class="action-label">{{label}}</span></button>
+ <button type="button" class="action-link action-{{actionId}}"><span aria-hidden="true">→ </span><span class="action-label">{{label}}</span></button>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| <button type="button" class="action-link action-{{actionId}}">→ <span class="action-label">{{label}}</span></button> | |
| <button type="button" class="action-link action-{{actionId}}"><span aria-hidden="true">→ </span><span class="action-label">{{label}}</span></button> |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Assets/WebsiteAssets/templates/partials/plan.mustache` at line 31, The
decorative arrow character before the action label is being read by screen
readers; update the button markup for the element with class "action-link" /
"action-{{actionId}}" so the arrow is marked aria-hidden (e.g., wrap the "→" in
a span and add aria-hidden="true" or set aria-hidden on the existing span) and
ensure the visible action label remains in the span with class "action-label" so
only the label is announced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request updates the website with a "Pro 100 GB" Joplin Cloud plan.
This pull request is currently a draft: There are supporting backend changes that still need to be merged and/or enabled.