fix: Ensure pod template annotations are rendered for provider deployments#20
Merged
nimrod-teich merged 2 commits intolavanet:mainfrom Jan 15, 2026
Merged
fix: Ensure pod template annotations are rendered for provider deployments#20nimrod-teich merged 2 commits intolavanet:mainfrom
nimrod-teich merged 2 commits intolavanet:mainfrom
Conversation
added 2 commits
December 10, 2025 16:37
nimrod-teich
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue in ArgoCD-managed deployments where
kubectl rollout restartwould create a new pod that was immediately terminated instead of performing a proper rolling restart.Root cause
The chart did not consistently render
spec.template.metadata.annotations. When no pod annotations were configured, the pod template effectively had no annotations map. During a rollout restart, kubectl temporarily injectskubectl.kubernetes.io/restartedAt, but in ArgoCD-managed deployments this change was later overwritten when the Deployment was reconciled from the rendered manifest. This caused the pod template hash to revert and the newly created ReplicaSet to be scaled down immediately.Fix
Ensure the pod template annotations block is rendered when pod annotations are provided. This stabilizes the pod template metadata and prevents the restart annotation from being removed during reconciliation, allowing Kubernetes to complete a normal rolling update.
Result
kubectl rollout restartnow behaves as expected in ArgoCD-managed deployments, replacing the old pod with a new one via a proper rolling deployment.