Change scheduler logic to "keep awake" #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch scheduler from current "turn on / turn off" logic to "keep on / end keep on" logic
fix typos
Instead of making new scheduler logic active for all users, only use the new logic if schedule_logic is set (to 1) in settings.tdb
On my machine today, my code threw an error on "unset ::scheduler_awake" because there was no such variable. I'm not sure how it got to that state, but am adding a -nocomplain option to the command to avoid the error.
This rolls back the last commit (adding the -nocomplain option) and fixes the problem properly. The issue is that at startup we might be in the middle of a scheduled period, and if so the awake flag should be set. This accomplishes two things: (1) it ensures the machine doesn't sleep until the schedule ends if we are mid-schedule at startup; and (2) it avoids the possibility that the awake flag isn't set when we get to the end of our scheduled time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch scheduler from current "turn on / turn off" logic to "keep on / end keep on" logic