profile details #376
profile details #376
Conversation
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: GitHub <[email protected]>
There was a problem hiding this comment.
Whoa, this is not good. We've just leaked an API token. Why is a token needed here?
This specific API token is now leaked to the world and needs to be deleted from whatever account created it, @vishalvivekm
Signed-off-by: Vivek Vishal <[email protected]>
Co-authored-by: Hortison <[email protected]> Signed-off-by: Vivek Vishal <[email protected]>
Co-authored-by: Hortison <[email protected]> Signed-off-by: Vivek Vishal <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
|
@vishalvivekm is this still "Draft"? |
@vishalvivekm is this still "Draft"? |
Apologies for missing the messages, no it's ready for review. |
| @@ -6,7 +6,7 @@ | |||
| <a class="navbar-brand" href="/"> | |||
| <span class="navbar-brand__logo navbar-logo"> | |||
| {{ $svg := resources.Get "icons/logo.svg" }} | |||
| <img class="footer-logo" src="{{ $svg.Permalink }}" alt="logo" /> | |||
| <img class="footer-logo" src="/images/logo.svg" alt="logo" /> | |||
There was a problem hiding this comment.
Why was this changed? What does it have to do with the avatar?
There was a problem hiding this comment.
Part of the reason that I’m asking is because I see that there is a footer logo class being used. I assume that this is the footer. Maybe the footer class needs to be renamed.
layouts/partials/navbar.html
Outdated
| <div class="logo-container"> | ||
| <img | ||
| src="/images/logos/meshery-light-icon.svg" | ||
| alt="Layer5 Meshery Logo" |
There was a problem hiding this comment.
There isn’t a Layer5 Meshery logo, just a Meshery logo.
| } | ||
|
|
||
| function getCookieValue(cookieName) { | ||
| const cookies = document.cookie.split(";"); |
There was a problem hiding this comment.
This sort of string parsing is never ideal. Is this what was done on the other sites, too?
There was a problem hiding this comment.
yeah this from layer5.io and meshery.layer5.io
Signed-off-by: GitHub <[email protected]>
|
Let's get a "Sign In" button presented in the corner when an anonymous visitor opens the site. Do you agree? 
|
|
Also, will you please put Kanvas and Cloud docs links on the left with Products on the right with avatar, like this: 
|
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Vivek Vishal <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: GitHub <[email protected]>
|
|
Signed-off-by: GitHub <[email protected]>
|
|
| if(e.target != dropdown && dropdown.classList.contains("current")){ | ||
| dropdown.classList.toggle("current"); | ||
| document.querySelector(".dropdown-menu").classList.toggle("show"); | ||
| function setupDropdown(dropdownId) { |
There was a problem hiding this comment.
A comment describing the function, would be great.
There was a problem hiding this comment.
@vivek Vishal, the following pertain to both Safari and Chrome:
- the app grid menu is bouncing around.
- in this recording the cursor style is not consistently "pointer", although in other tests is seems fine.
- the app grid should darken in color on hover.
Screen.Recording.2024-10-16.at.10.53.45.AM.mov
|
Each app button should be of equal size. |
|
Is this javascript really needed? CSS ::active doesn't cut it? |
Notes for Reviewers
This PR adds
Signed commits