Updatess #394
Closed
Updatess #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ricing-list workflow Signed-off-by: Ankita Sahu <[email protected]>
Signed-off-by: Ankita Sahu <[email protected]>
Co-authored-by: Matthieu Evrin <[email protected]> Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Ankita Sahu <[email protected]>
Signed-off-by: Ankita Sahu <[email protected]>
Signed-off-by: GitHub <[email protected]>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vishalvivekm
commented
Oct 19, 2024
vishalvivekm
commented
Oct 19, 2024
Signed-off-by: Vivek Vishal <[email protected]>
vishalvivekm
commented
Oct 19, 2024
Signed-off-by: Vivek Vishal <[email protected]>
vishalvivekm
commented
Oct 19, 2024
There was a problem hiding this comment.
this file is included in the commit for the sake of preview
There was a problem hiding this comment.
Will this file be persisted to the repo?
leecalcote
reviewed
Oct 19, 2024
leecalcote
reviewed
Oct 19, 2024
| update-pricing-and-frontmatter: | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| PRICING_FILE: 'pricing-data.json' |
There was a problem hiding this comment.
Rename variable and file, @SAHU-01
leecalcote
reviewed
Oct 19, 2024
| PRICING_FILE: 'pricing-data.json' | ||
|
|
||
| steps: | ||
| - name: Trigger Pricing List workflow and wait for completion |
leecalcote
requested changes
Oct 19, 2024
| steps: | ||
| - name: Trigger Pricing List workflow and wait for completion | ||
| id: trigger-workflow | ||
| run: | |
There was a problem hiding this comment.
Use GitHub native call, not an API call, @SAHU-01
leecalcote
reviewed
Oct 19, 2024
|
|
||
| echo "Triggered workflow, waiting for completion..." | ||
|
|
||
| while true; do |
leecalcote
reviewed
Oct 19, 2024
| run: | | ||
| git config --local user.email "[email protected]" | ||
| git config --local user.name "GitHub Action" | ||
| git add ${{ env.PRICING_FILE }} |
leecalcote
reviewed
Oct 19, 2024
| with: | ||
| go-version: '1.21' | ||
|
|
||
| - name: Run update_frontmatter.go |
There was a problem hiding this comment.
Is a go program really necessary?
leecalcote
reviewed
Oct 19, 2024
| git config --local user.email "[email protected]" | ||
| git config --local user.name "GitHub Action" | ||
| git add ${{ env.PRICING_FILE }} | ||
| git diff --quiet && git diff --staged --quiet || (git commit -m "Update front matter based on new pricing data" && git push) |
leecalcote
reviewed
Oct 19, 2024
| git config --local user.email "[email protected]" | ||
| git config --local user.name "GitHub Action" | ||
| git add ${{ env.PRICING_FILE }} | ||
| git diff --quiet && git diff --staged --quiet || (git commit -m "Update front matter based on new pricing data" && git push) |
There was a problem hiding this comment.
Don't use git commands. Use the same autocommitter that we use in many other workflows.
leecalcote
reviewed
Oct 19, 2024
| .matterinfo { | ||
| font-weight: $font-weight-medium; | ||
| background: $black; | ||
| font-family: "Open Sans"; |
leecalcote
reviewed
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #
Signed commits