Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced Lee's Photos with Five images #5256

Closed
wants to merge 68 commits into from

Conversation

nwanduka
Copy link
Contributor

@nwanduka nwanduka commented Jan 1, 2024

Replaced Lee's photos with images of Five in the community page

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Victoria Nduka <[email protected]>
Signed-off-by: Victoria Nduka <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jan 1, 2024

🚀 Preview for commit 01cf51c at: https://65933108bae3c006fb8ff4af--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Jan 3, 2024

🚀 Preview for commit 3e4bcd1 at: https://659568cedbb1c80098cbc205--layer5.netlify.app

Signed-off-by: Victoria Nduka <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jan 3, 2024

🚀 Preview for commit c75ee74 at: https://65956c33b8ce00032852c010--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Jan 4, 2024

🚀 Preview for commit 4c4a9b3 at: https://65973875993dc54ad984325b--layer5.netlify.app

Signed-off-by: Victoria Nduka <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jan 4, 2024

🚀 Preview for commit 17a212a at: https://65974118a9f3f6504367fd5a--layer5.netlify.app

Signed-off-by: Victoria Nduka <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jan 4, 2024

🚀 Preview for commit 3156c89 at: https://6597457d2209f14e6ace15ff--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Jan 8, 2024

🚀 Preview for commit 2e57e44 at: https://659be30f4804834fd7fabd03--layer5.netlify.app

Signed-off-by: Victoria Nduka <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jan 8, 2024

🚀 Preview for commit 1513c8d at: https://659bea414cfc79524c7e8a20--layer5.netlify.app

Signed-off-by: Victoria Nduka <[email protected]>
Signed-off-by: Victoria Nduka <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jan 8, 2024

🚀 Preview for commit b8eb698 at: https://659bf0c2f50dbf144c03c544--layer5.netlify.app

Signed-off-by: Victoria Nduka <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jan 8, 2024

🚀 Preview for commit 087f3c5 at: https://659c0a4da5c08502dc3ed1c4--layer5.netlify.app

Signed-off-by: Victoria Nduka <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jan 8, 2024

🚀 Preview for commit 242b2c7 at: https://659c0da0de69a40ebd354f82--layer5.netlify.app

Signed-off-by: Victoria Nduka <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jan 13, 2024

🚀 Preview for commit 7c27b4d at: https://65a29ba9016b53c989d06c7d--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Feb 19, 2024

🚀 Preview for commit e0a3a24 at: https://65d34686041c3b00872a4080--layer5.netlify.app

thumbnail update

Signed-off-by: Victoria Nduka <[email protected]>
Signed-off-by: Victoria Nduka <[email protected]>
@l5io
Copy link
Contributor

l5io commented Feb 19, 2024

🚀 Preview for commit 90cadad at: https://65d356442e81520fa4c57498--layer5.netlify.app

changed video to image

Signed-off-by: Victoria Nduka <[email protected]>
Signed-off-by: Victoria Nduka <[email protected]>
Signed-off-by: Victoria Nduka <[email protected]>
import JoinCommunity from "../Community/Join-community";
import CareersSectionWrapper from "./careers.style";

const Lee_and_Rigs = "../../assets/images/careers/Lee-and-Rigs-Caballero-of-Google.jpeg";
const Lee_and_Rigs = "../../assets/images/careers/Five.png";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use svg here?

import JoinCommunity from "../Community/Join-community";
import CareersSectionWrapper from "./careers.style";

const Lee_and_Rigs = "../../assets/images/careers/Lee-and-Rigs-Caballero-of-Google.jpeg";
const Five = "../../assets/images/careers/Five.svg";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nwanduka can you please change the variable name as the same has been used on line 7 causing build issues

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh.. okay. Thanks for pointing that out.

Signed-off-by: Victoria Nduka <[email protected]>
Signed-off-by: Victoria Nduka <[email protected]>
@l5io
Copy link
Contributor

l5io commented Feb 21, 2024

🚀 Preview for commit 58edef6 at: https://65d654bf0c8e58fbd5c5db52--layer5.netlify.app

fix image rendering in careers page

Signed-off-by: Victoria Nduka <[email protected]>
Signed-off-by: Victoria Nduka <[email protected]>
Signed-off-by: Victoria Nduka <[email protected]>
@l5io
Copy link
Contributor

l5io commented Mar 18, 2024

🚀 Preview for commit 300d51b at: https://65f82d25d3f0445a91eb97ff--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Mar 18, 2024

🚀 Preview for commit 3313361 at: https://65f83d702115b967d31a0004--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Mar 18, 2024

🚀 Preview for commit b8096e0 at: https://65f8408b14875869e7079c89--layer5.netlify.app

Signed-off-by: Victoria Nduka <[email protected]>
Signed-off-by: Victoria Nduka <[email protected]>
@l5io
Copy link
Contributor

l5io commented Mar 18, 2024

🚀 Preview for commit ef0d457 at: https://65f845780df21d6c21ec2d51--layer5.netlify.app

Signed-off-by: Victoria Nduka <[email protected]>
@l5io
Copy link
Contributor

l5io commented Mar 18, 2024

🚀 Preview for commit ab0f61c at: https://65f84e0cc265726fc8aa249b--layer5.netlify.app

Signed-off-by: Victoria Nduka <[email protected]>
@l5io
Copy link
Contributor

l5io commented Mar 18, 2024

🚀 Preview for commit 387ccd0 at: https://65f853491487587998079f6c--layer5.netlify.app

@iArchitSharma
Copy link
Contributor

@nwanduka are you done here?

@leecalcote
Copy link
Member

Merge conflicts

@ritiksaxena124
Copy link
Contributor

This item is completed by another PR which is merged. So closing this. Thank you @nwanduka 🙌 for taking this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants