Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update animations direction: from top to bottom to bottom to top #5391

Closed
wants to merge 4 commits into from
Closed

Update animations direction: from top to bottom to bottom to top #5391

wants to merge 4 commits into from

Conversation

Ashparshp
Copy link
Contributor

@Ashparshp Ashparshp commented Feb 12, 2024

Description
Update animations direction: from top to bottom to bottom to top

This PR fixes #5344

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@Ashparshp
Copy link
Contributor Author

@iArchitSharma Please have a look and help me..

@l5io
Copy link
Contributor

l5io commented Feb 12, 2024

🚀 Preview for commit 018b8df at: https://65ca0f5ecd4bfbe08a307077--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Feb 12, 2024

🚀 Preview for commit 4fca5f9 at: https://65ca1992722bc9e3456e67db--layer5.netlify.app

@iArchitSharma
Copy link
Contributor

@Ashparshp Always remember to to sign off your commit git commit -s otherwise the DCO check will fail

@Ashparshp
Copy link
Contributor Author

Ashparshp commented Feb 12, 2024

I followed the procedures but still.. Maybe I have made a mistake.. Now, what to do?

@iArchitSharma
Copy link
Contributor

@Ashparshp, no problem. I've fixed the check. You can now focus on the issue you are working on

@iArchitSharma
Copy link
Contributor

@Ashparshp yes you can, but always do git pull locally once you update branch

@Ashparshp Ashparshp marked this pull request as ready for review February 15, 2024 14:54
@Ashparshp
Copy link
Contributor Author

I'll keep in mind!

@l5io
Copy link
Contributor

l5io commented Feb 15, 2024

🚀 Preview for commit 3a5e6dd at: https://65ce28918e1349213941a144--layer5.netlify.app

@ritiksaxena124
Copy link
Contributor

@Ashparshp it might be possible that the user will scroll to that section after a few seconds so the user will miss that animation in the current implementation. Please fix that too. Show animation when that section comes inside the viewport.

@saurabh100ni
Copy link
Contributor

Hi @Ashparshp ,
Thanks for your PR! I encourage you to share this in the Website Meeting on Monday at 6:30 PM IST. Share your screen, and walk us through it. It's cool to take and share feedback. Check the Doc here to include this PR.

You're welcome at the meeting

Check to community calendar for more details of meetings at Layers.

@l5io
Copy link
Contributor

l5io commented Feb 20, 2024

🚀 Preview for commit 555d2a1 at: https://65d4593c472a4097640aeff9--layer5.netlify.app

@iArchitSharma
Copy link
Contributor

@Ashparshp are you still working on it?

@Ashparshp
Copy link
Contributor Author

@iArchitSharma Apologies for the delay in response. Yes, I'm still actively working on it. I'll create a new PR for the inview animations shortly.

@iArchitSharma
Copy link
Contributor

@Ashparshp No updates??

@Ashparshp
Copy link
Contributor Author

@iArchitSharma Sorry for being inactive; exams, projects, and assignments have been keeping me busy. I'll be available by 12 once my exams are over tomorrow.

@iArchitSharma
Copy link
Contributor

@Ashparshp are you still working on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Add animations to a section
5 participants