-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update animations direction: from top to bottom to bottom to top #5391
Conversation
Signed-off-by: Ashparsh <[email protected]>
@iArchitSharma Please have a look and help me.. |
🚀 Preview for commit 018b8df at: https://65ca0f5ecd4bfbe08a307077--layer5.netlify.app |
🚀 Preview for commit 4fca5f9 at: https://65ca1992722bc9e3456e67db--layer5.netlify.app |
@Ashparshp Always remember to to sign off your commit |
I followed the procedures but still.. Maybe I have made a mistake.. Now, what to do? |
@Ashparshp, no problem. I've fixed the check. You can now focus on the issue you are working on |
@Ashparshp yes you can, but always do |
I'll keep in mind! |
🚀 Preview for commit 3a5e6dd at: https://65ce28918e1349213941a144--layer5.netlify.app |
@Ashparshp it might be possible that the user will scroll to that section after a few seconds so the user will miss that animation in the current implementation. Please fix that too. Show animation when that section comes inside the viewport. |
Hi @Ashparshp , You're welcome at the meeting Check to community calendar for more details of meetings at Layers. |
🚀 Preview for commit 555d2a1 at: https://65d4593c472a4097640aeff9--layer5.netlify.app |
@Ashparshp are you still working on it? |
@iArchitSharma Apologies for the delay in response. Yes, I'm still actively working on it. I'll create a new PR for the inview animations shortly. |
@Ashparshp No updates?? |
@iArchitSharma Sorry for being inactive; exams, projects, and assignments have been keeping me busy. I'll be available by 12 once my exams are over tomorrow. |
@Ashparshp are you still working on it? |
Description
Update animations direction: from top to bottom to bottom to top
This PR fixes #5344
Notes for Reviewers
Signed commits