Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Screenshots] added for both integration External Secrets Operator #5328 & Dex #5319 #5413

Closed
wants to merge 12 commits into from
Closed

[Screenshots] added for both integration External Secrets Operator #5328 & Dex #5319 #5413

wants to merge 12 commits into from

Conversation

meetjn
Copy link
Contributor

@meetjn meetjn commented Feb 18, 2024 •
edited
Loading

Description

This PR fixes #5328

Notes for Reviewers

Added both Dark Mode and Light Mode screenshots.

designer dark designer light visualizer dark visualizer light

Signed commits

@meetjn
<commit subject>
d31cdf3 
Signed-off-by: Meet Jain <[email protected]>
vishalvivekm
vishalvivekm requested changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preview is failing.
have suggested some changes, they might fix it.

@l5io
Copy link
Contributor

l5io commented Feb 22, 2024

🚀 Preview for commit 989750b at: https://65d6ec7d0c8e5866d8c5dbcd--layer5.netlify.app

@meetjn meetjn requested a review from vishalvivekm February 22, 2024 09:01
@meetjn
Copy link
Contributor Author

meetjn commented Feb 22, 2024

preview is failing. have suggested some changes, they might fix it.

Updated the suggested changes.

vishalvivekm
vishalvivekm requested changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There're not changes @meetjn

image

Where're the screenshots and the directory I previously mentioned under _images/

https://65d6ec7d0c8e5866d8c5dbcd--layer5.netlify.app/cloud-native-management/meshery/integrations/external-secrets-operator

@meetjn
<commit subject>
821e386 
Signed-off-by: Meet Jain <[email protected]>
@meetjn
Copy link
Contributor Author

meetjn commented Feb 24, 2024

There're not changes @meetjn

image

Where're the screenshots and the directory I previously mentioned under _images/

https://65d6ec7d0c8e5866d8c5dbcd--layer5.netlify.app/cloud-native-management/meshery/integrations/external-secrets-operator

Updated screenshots with the file paths and new directory under _images

@meetjn meetjn requested a review from vishalvivekm February 24, 2024 02:59
@l5io
Copy link
Contributor

l5io commented Feb 24, 2024

🚀 Preview for commit 821e386 at: https://65d95c34145040971390d67c--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Feb 24, 2024

🚀 Preview for commit 9d0c238 at: https://65d96cb7fd55299b3dec9be6--layer5.netlify.app

@meetjn meetjn changed the title [Screenshots] added for integration External Secrets Operator #5328 [Screenshots] added for both integration External Secrets Operator #5328 & Dex #5319 Feb 24, 2024
vishalvivekm
vishalvivekm requested changes Feb 25, 2024
View reviewed changes
.gitpod.yml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert this change.

src/collections/integrations/_images/External-secrets-operator/designDark.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

external-secrets-operator not External-secrets-operator

@meetjn meetjn closed this Feb 25, 2024
@meetjn meetjn reopened this Feb 25, 2024
@meetjn meetjn closed this Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalvivekm vishalvivekm vishalvivekm requested changes

Assignees
No one assigned
Labels
project/meshery
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Screenshots] External Secrets Operator under 'How it Works See It in Action' section
3 participants
@meetjn @l5io @vishalvivekm