-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kanvas sistent badge to member, and sistent badge to recognition #6211
Add kanvas sistent badge to member, and sistent badge to recognition #6211
Conversation
Signed-off-by: Deeptanshu Sankhwar <[email protected]>
🚀 Preview for commit 5909782 at: https://679a8e2385b64469d00fdff2--layer5.netlify.app |
@Deeptanshu-sankhwar adding it as an agenda item to the meeting minutes. |
Hi @vishalvivekm , joining today's call would be a little hard for me. It would be very early morning for me, would you please mention it during the call, I'll go over the youtube recording and make the necessary changes within the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Deeptanshu-sankhwar why png and svg both?
Not sure @sudhanshutech . They were just kinda mentioned in the reference(#6205), hence I added both. Is it safe to remove the |
🚀 Preview for commit abc9848 at: https://67a9cfba2e87765e957e9843--layer5.netlify.app |
What can we do to close it? @vishalvivekm @sudhanshutech |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @Deeptanshu-sankhwar
Description
members.js
with the new graphicmembers.js
recognition.js
This PR fixes #6205
Notes for Reviewers


The new graphics look a bit off as compared to others for
kanvas
andsistent
, is this the right behavior, or do theicon-only
graphics need to be used for bothkanvas
andsistent
?Signed commits