Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Implement functionality for "Start Free Trial" and "Join For Fre… #6303

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix: Implement functionality for "Start Free Trial" and "Join For Fre… #6303

wants to merge 5 commits into from

Conversation

Dungeon-Masterji
Copy link
Contributor

@Dungeon-Masterji Dungeon-Masterji commented Mar 10, 2025 •
edited
Loading

Fixes: #6293, #6276

Description:
This PR resolves both #6293 and #6276 as they involve changes in the same code execution flow. While issue #6276 was assigned to @tanishq3105, the fix required modifications in the same logic affected by #6293, making it necessary to address both together.

Changes Implemented:

Why this approach?
Since both issues required changes in overlapping parts of the code, it was more efficient to fix them together rather than creating separate PRs. This ensures code consistency and avoids conflicts.

How to Test?

Screen.Recording.2025-03-10.at.4.mp4

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Mar 10, 2025

🚀 Preview for commit 660701c at: https://67cecc01d8b87904650c3b5d--layer5.netlify.app

@leecalcote
Copy link
Member

Thanks, @Dungeon-Masterji!

@leecalcote leecalcote requested a review from falgunmpatel March 12, 2025 21:19
@vishalvivekm
Copy link
Contributor

@Dungeon-Masterji
Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST

adding it as an agenda item to the meeting minutes.

vishalvivekm
vishalvivekm requested changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback offered on sites call, would need be incorporated.

Dungeon-Masterji added a commit to Dungeon-Masterji/layer5 that referenced this pull request Mar 18, 2025
@Dungeon-Masterji
Updated contact sales button and pricing section layer5io#6303
1fdfde0 
Signed-off-by: Aditya Raj <[email protected]>
@l5io
Copy link
Contributor

l5io commented Mar 18, 2025

🚀 Preview for commit 1fdfde0 at: https://67d9378cd0b0a7d2ef3a63c1--layer5.netlify.app

Dungeon-Masterji added a commit to Dungeon-Masterji/layer5 that referenced this pull request Mar 18, 2025
@Dungeon-Masterji
Updated contact sales button and pricing section layer5io#6303
27cc07b 
Signed-off-by: Aditya Raj <[email protected]>

Fix lint errors and update dependencies
dependabot bot and others added 2 commits March 18, 2025 15:02
@dependabot @Dungeon-Masterji
Bump @emotion/react from 11.13.3 to 11.14.0
71d6c68 
Bumps [@emotion/react](https://github.com/emotion-js/emotion) from 11.13.3 to 11.14.0.
- [Release notes](https://github.com/emotion-js/emotion/releases)
- [Changelog](https://github.com/emotion-js/emotion/blob/main/CHANGELOG.md)
- [Commits](https://github.com/emotion-js/emotion/compare/@emotion/[email protected]...@emotion/[email protected])

---
updated-dependencies:
- dependency-name: "@emotion/react"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@Dungeon-Masterji
Fix: Implement functionality for "Start Free Trial" and "Join For Fre…
42f7ba1 
…e" buttons

This update adds interactive functionality to the "Start Free Trial" and "Join For Free" buttons, ensuring they trigger the expected actions when clicked

Signed-off-by: Aditya Raj <[email protected]>
Dungeon-Masterji added a commit to Dungeon-Masterji/layer5 that referenced this pull request Mar 18, 2025
@Dungeon-Masterji
Updated contact sales button and pricing section layer5io#6303
f2a22a6 
Signed-off-by: Aditya Raj <[email protected]>

Fix lint errors and update dependencies

updated Fix button
@l5io
Copy link
Contributor

l5io commented Mar 18, 2025

🚀 Preview for commit f2a22a6 at: https://67d940af7b3485e6688a6bee--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Mar 18, 2025

🚀 Preview for commit def0680 at: https://67d94893245c83f78363200d--layer5.netlify.app

@Dungeon-Masterji
Copy link
Contributor Author

Feedback offered on sites call, would need be incorporated.

@vishalvivekm , I have made the changes we discussed. Also, apologies for the .gitignore update from -spreadsheet.csv to +spreadsheet.csv. I hope this update is fine—next time, I’ll keep in mind that keeping changes minimal helps reviewers focus on key updates. I think it's perfectly good for a merge. Please check it.

vishalvivekm
vishalvivekm requested changes Mar 23, 2025
View reviewed changes
Copy link
Contributor

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert dep changes in package.json

@Dungeon-Masterji
Update .gitignore
7cc534b 
Signed-off-by: Aditya Raj <[email protected]>

Updated contact sales button and pricing section layer5io#6303

Signed-off-by: Aditya Raj <[email protected]>

Fix lint errors and update dependencies

updated Fix button
@Dungeon-Masterji
Revert "Bump @emotion/react from 11.13.3 to 11.14.0"
7afbdd6 
This reverts commit 71d6c68.
@Dungeon-Masterji
Revert "Update .gitignore"
a746878 
This reverts commit def0680.

Signed-off-by: Aditya Raj <[email protected]>
@l5io
Copy link
Contributor

l5io commented Mar 23, 2025

🚀 Preview for commit a746878 at: https://67e04f0193ff298e4bfe404c--layer5.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalvivekm vishalvivekm vishalvivekm requested changes

@sudhanshutech sudhanshutech sudhanshutech approved these changes

@falgunmpatel falgunmpatel falgunmpatel approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
6 participants
@Dungeon-Masterji @l5io @leecalcote @vishalvivekm @sudhanshutech @falgunmpatel