Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added employee badges to members and recognition page #6304

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

0x-74
Copy link

@0x-74 0x-74 commented Mar 10, 2025

Description

This PR fixes #6277

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Mar 10, 2025

🚀 Preview for commit 84afdb1 at: https://67cee93babd2b40a44442371--layer5.netlify.app

Signed-off-by: Aviral Jain <[email protected]>
@l5io
Copy link
Contributor

l5io commented Mar 10, 2025

🚀 Preview for commit 293d48c at: https://67cef310b68a7d009242342d--layer5.netlify.app

@0x-74
Copy link
Author

0x-74 commented Mar 11, 2025

@vishalvivekm

@vishalvivekm
Copy link
Contributor

@0x-74 please move from role to badges

@vishalvivekm
Copy link
Contributor

#6277 (comment)

@0x-74
Copy link
Author

0x-74 commented Mar 11, 2025

@vishalvivekm what do you mean?

@vishalvivekm
Copy link
Contributor

@vishalvivekm what do you mean?

@0x-74 these changes, while have added the employee badge to handbook's recognition section, haven't made the badge available on /community/members page i.e. it can't be awarded to a particular profile like other badges, such as Meshery badge.

Instead, it's in Roles, ( both Maintainer and Employee roles use the same 5 icon), but if you come to think of it, an individual can be both a maintainer and an employee e.g. Amit Amruitya, how should we account for this situation? Any thoughts?

Another point to consider: should we add a flare to an employee's profile, similar to what we do for MeshMates?

@leecalcote leecalcote requested review from falgunmpatel and vishalvivekm and removed request for falgunmpatel March 12, 2025 23:22
@vishalvivekm
Copy link
Contributor

@0x-74 thoughts ?

@0x-74
Copy link
Author

0x-74 commented Mar 15, 2025

hey @vishalvivekm sorry for the late reply! i am actually able to add it as a badge so i dont quite understand that point
WhatsApp Image 2025-03-15 at 21 27 07 , i feel that unlike meshmates , there are quite a lot of employees and giving them a flare isnt particularly functional as you dont have the need to contact employees directly for help i think?, the icon needs to be redesigned actually for an employee and maintainers both actually! if people are open to it i would design an icon for both, i dont think the current icons for either represent the roles appropriately!

@vishalvivekm
Copy link
Contributor

@0x-74
Thank you for your contribution!
Let's discuss this during the website call today at 5:30 PM IST

adding it as an agenda item to the meeting minutes.

@l5io
Copy link
Contributor

l5io commented Mar 17, 2025

🚀 Preview for commit c4ce41c at: https://67d7f8c5e50e2c7fbaad238f--layer5.netlify.app

@0x-74
Copy link
Author

0x-74 commented Mar 17, 2025

Hey @vishalvivekm i couldn't attend the meeting due to a meeting at my company, is it possible to connect elsewhere or can I get some task updates right here?

@0x-74
Copy link
Author

0x-74 commented Mar 20, 2025

@vishalvivekm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Add Employee badge to members and recognition pages
3 participants