-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Handbook] Add new meshery-extensions org #6310 #6340
base: master
Are you sure you want to change the base?
Conversation
🚀 Preview for commit 736121f at: https://67de6e6fc32c9d98f4c48def--layer5.netlify.app |
@Dungeon-Masterji, there is a UI issue with the bullet point. It would be helpful if you could address this along with the lint checks which are failing. |
736121f
to
8728437
Compare
🚀 Preview for commit 8728437 at: https://67df183d0e8e8e5d96b61370--layer5.netlify.app |
🚀 Preview for commit ffe59c9 at: https://67df1f80156b6ebec573a44f--layer5.netlify.app |
🚀 Preview for commit 49d6862 at: https://67df23dd93ff2965d1fe3caf--layer5.netlify.app |
Signed-off-by: Aditya Raj <[email protected]> fix: run eslint Signed-off-by: Aditya Raj <[email protected]> Remove unnecessary files Signed-off-by: Aditya Raj <[email protected]> Updated my blog as everyone suggested Signed-off-by: Aditya Raj <[email protected]>
49d6862
to
ec6e257
Compare
🚀 Preview for commit ec6e257 at: https://67df27e1c4fd606d32f7a9fd--layer5.netlify.app |
@Dungeon-Masterji adding it as an agenda item to the meeting minutes. |
🚀 Preview for commit c7a9a1f at: https://67e042308956cff4cf90eea1--layer5.netlify.app |
It's fixed ✅ https://mesheryio.slack.com/archives/C015QJKUMPU/p1742750085637569?thread_ts=1742747028.376629&cid=C015QJKUMPU |
src={meshery} | ||
alt="meshery icon" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use meshery extensions icon, see #6323
https://github.com/layer5io/layer5/pull/6323/files#diff-4394dbcb17beff14e04045ad62eb744e1c8edd8ec603536615ee3efd536e7eb0
🚀 Preview for commit dd8b904 at: https://67e04aa48956cfff5c90ee98--layer5.netlify.app |
Signed-off-by: Aditya Raj <[email protected]>
🚀 Preview for commit 874765e at: https://67e060ceaae33f3cf7ca0173--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the image is already available at src/assets/images/meshery-extensions/icon-only/meshery-extensions-color.svg
Signed-off-by: Vivek Vishal <[email protected]>
Hi @vishalvivekm, I couldn’t find the image at the mentioned path, and all checks are failing. Could you confirm if the image is elsewhere or needs to be added? Also, any pointers on fixing the checks would be great. Thanks! |
Signed-off-by: Vivek Vishal <[email protected]>
Fixed : ✅ |
hey @Dungeon-Masterji |
🚀 Preview for commit 15b3b40 at: https://67e06956c4fd60aacef7abe6--layer5.netlify.app |
Hi @gourav-k-shaw , |
Description
Current Behavior
The community handbook has a repository overview. That overview is missing an entry for the new https://github.com/meshery-extensions org.
Desired Behavior
Add this new org and a description to the repo overview.
This PR fixes #6310
Notes for Reviewers
Signed commits