Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Handbook] Add new meshery-extensions org #6310 #6340

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Dungeon-Masterji
Copy link
Contributor

Description
Current Behavior
The community handbook has a repository overview. That overview is missing an entry for the new https://github.com/meshery-extensions org.

Desired Behavior
Add this new org and a description to the repo overview.

This PR fixes #6310

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Mar 22, 2025

🚀 Preview for commit 736121f at: https://67de6e6fc32c9d98f4c48def--layer5.netlify.app

@yash37158
Copy link
Contributor

yash37158 commented Mar 22, 2025

Screenshot 2025-03-22 at 7 27 31 PM

@Dungeon-Masterji, there is a UI issue with the bullet point. It would be helpful if you could address this along with the lint checks which are failing.

@github-actions github-actions bot added the area/blog New posts or new blog functionality label Mar 22, 2025
@l5io
Copy link
Contributor

l5io commented Mar 22, 2025

🚀 Preview for commit 8728437 at: https://67df183d0e8e8e5d96b61370--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Mar 22, 2025

🚀 Preview for commit ffe59c9 at: https://67df1f80156b6ebec573a44f--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Mar 22, 2025

🚀 Preview for commit 49d6862 at: https://67df23dd93ff2965d1fe3caf--layer5.netlify.app

Signed-off-by: Aditya Raj <[email protected]>

fix: run eslint

Signed-off-by: Aditya Raj <[email protected]>

Remove unnecessary files

Signed-off-by: Aditya Raj <[email protected]>

Updated my blog as everyone suggested

Signed-off-by: Aditya Raj <[email protected]>
@l5io
Copy link
Contributor

l5io commented Mar 22, 2025

🚀 Preview for commit ec6e257 at: https://67df27e1c4fd606d32f7a9fd--layer5.netlify.app

@vishalvivekm
Copy link
Contributor

vishalvivekm commented Mar 23, 2025

@Dungeon-Masterji
Thank you for your contribution!
Let's discuss this during the website call on Monday at 5:30 PM IST

adding it as an agenda item to the meeting minutes.

@l5io
Copy link
Contributor

l5io commented Mar 23, 2025

🚀 Preview for commit c7a9a1f at: https://67e042308956cff4cf90eea1--layer5.netlify.app

@vishalvivekm
Copy link
Contributor

@Dungeon-Masterji, there is a UI issue with the bullet point. It would be helpful if you could address this along with the lint checks which are failing.

It's fixed ✅ https://mesheryio.slack.com/archives/C015QJKUMPU/p1742750085637569?thread_ts=1742747028.376629&cid=C015QJKUMPU

Comment on lines 127 to 128
src={meshery}
alt="meshery icon"
Copy link
Contributor

@vishalvivekm vishalvivekm Mar 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l5io
Copy link
Contributor

l5io commented Mar 23, 2025

🚀 Preview for commit dd8b904 at: https://67e04aa48956cfff5c90ee98--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Mar 23, 2025

🚀 Preview for commit 874765e at: https://67e060ceaae33f3cf7ca0173--layer5.netlify.app

Copy link
Contributor

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the image is already available at src/assets/images/meshery-extensions/icon-only/meshery-extensions-color.svg

@Dungeon-Masterji
Copy link
Contributor Author

the image is already available at src/assets/images/meshery-extensions/icon-only/meshery-extensions-color.svg

Hi @vishalvivekm,

I couldn’t find the image at the mentioned path, and all checks are failing. Could you confirm if the image is elsewhere or needs to be added? Also, any pointers on fixing the checks would be great.

Thanks!

@vishalvivekm
Copy link
Contributor

vishalvivekm commented Mar 23, 2025

the image is already available at src/assets/images/meshery-extensions/icon-only/meshery-extensions-color.svg

Hi @vishalvivekm,

I couldn’t find the image at the mentioned path, and all checks are failing. Could you confirm if the image is elsewhere or needs to be added? Also, any pointers on fixing the checks would be great.

Thanks!

Fixed : ✅
You needed to update the import path to /assets/images/meshery-extensions/icon-only and yes the image is here: https://github.com/layer5io/layer5/blob/master/src/assets/images/meshery-extensions/icon-only/meshery-extensions-color.svg

@gourav-k-shaw
Copy link
Contributor

hey @Dungeon-Masterji
may you please keep the variable names consistent with my PR. as my PR already got merged. as both the file refer to the same icon

@l5io
Copy link
Contributor

l5io commented Mar 23, 2025

🚀 Preview for commit 15b3b40 at: https://67e06956c4fd60aacef7abe6--layer5.netlify.app

@Dungeon-Masterji
Copy link
Contributor Author

hey @Dungeon-Masterji may you please keep the variable names consistent with my PR. as my PR already got merged. as both the file refer to the same icon

Hi @gourav-k-shaw ,
I Got it! This time, @vishalvivekm helped me with the changes—big thanks to him. I’ll make sure to update my branch properly next time to avoid this issue. Appreciate your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/blog New posts or new blog functionality area/handbook
Development

Successfully merging this pull request may close these issues.

[Handbook] Add new meshery-extensions org
5 participants