Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ench: ActionButton for new designs #667

Merged
merged 3 commits into from
Jul 5, 2024
Merged

ench: ActionButton for new designs #667

merged 3 commits into from
Jul 5, 2024

Conversation

dottharun
Copy link
Contributor

@dottharun dottharun commented Jul 5, 2024 •
edited
Loading

Notes for Reviewers

This PR enriches ActionButton by

  • adding show field for skip showing options
  • adding Divider option to show divider in dropdown
  • defaultActionDisabled to disable the default button when not allowed

Signed commits

  • Yes, I signed my commits.

@dottharun dottharun changed the title style: ActionButton for new designs ench: ActionButton for new designs Jul 5, 2024
leecalcote
leecalcote approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leecalcote leecalcote merged commit 96a18bb into layer5io:master Jul 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dottharun @leecalcote