Add threaded scheduling to TickedScheduler
#8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
🤖 Code FormattingYour PR still has some code formatting issues. I've updated PR #9 with the necessary formatting changes. You can merge that PR into this branch to fix the code style check. Alternatively, you can run |
This test will fail if a `TickedScheduler` does not wait until all jobs are completed before consuming a tick and moving to the next tick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Threading now works in quite a simple way. The
Schedulercan dispatch different jobs to the different threads, but waits to collect all results from all tasks before moving to the next tick. In that way, we ensure that only one tick can be processed at every time, since the processing of a tick is an atomic job.