update CloudwatchLogs credential object

[yzpaul]

allows user provided credentials to work. Prior version was not nested correctly therefore AWS SDK ignored it and used default credentials

[nikhilrajaram]

How are you instantiating the WinstonCloudWatch transport? When I do so via:

new WinstonCloudWatch({
  ...,
  awsAccessKeyId,
  awsSecretKey,
  awsRegion,
})

This fix doesn't work. Specifically because in CloudWatchLogsClientConfig, region is specified at the same level of credentials.

Additionally, I believe this proposed fix would break the transport for those who:

1. only specify region and allow AWS SDK to pull creds from the IAM role
2. specify the CloudWatchLogsClientConfig directly though awsOptions

Thus, I would propose something like changing line 40 to:

config = {
  credentials: {
    accessKeyId: awsAccessKeyId,
    secretAccessKey: awsSecretKey,
  },
  region: awsRegion
};

And this line back to its original

this.cloudwatchlogs = new CloudWatchLogs(config);

[lazywithclass]

I agree with @nikhilrajaram, what do you think @yzpaul?

[yzpaul]

@lazywithclass yes @nikhilrajaram is right according to the docs, I didn't notice that issue because all of my test cases were in the same region.

[yzpaul]

@lazywithclass I'm fairly new to GitHub, should I incorporate his proposed change and do another pull request? How is this supposed to work so everything stays clean?

[lazywithclass]

Looks like you solved the problem :D

Do these changes solve the issue for you?

[yzpaul]

@lazywithclass yep, works for me, although I haven't set up an account in another region to confirm it, this seems right according to the docs

[yzpaul]

@nikhilrajaram <https://github.com/nikhilrajaram> is absolutely correct, I never noticed the region issue because in my testing all of my test cases were in the same region.

…

On Mon, Jun 27, 2022, 14:04 Alberto Zaccagni ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In index.js <#192 (comment)> : > @@ -49,7 +49,7 @@ var WinstonCloudWatch = function(options) { config = assign(config, options.awsOptions); } - this.cloudwatchlogs = new CloudWatchLogs(config); + this.cloudwatchlogs = new CloudWatchLogs({credentials:config}); I agree with @nikhilrajaram <https://github.com/nikhilrajaram>, what do you think @yzpaul <https://github.com/yzpaul>? — Reply to this email directly, view it on GitHub <#192 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABKDOOXXCLCGCLPMFCOWAETVRHUKDANCNFSM5ZOOYUQA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[lazywithclass]

@yzpaul sorry I am confused by your last comment, is the region issue solved by your last push?

If so I will test this in different regions and then publish a new version.