Issue3544 heat pump rtu controls by karthikeyad-pnnl · Pull Request #3545 · lbl-srg/modelica-buildings

karthikeyad-pnnl · 2023-10-01T04:10:53Z

Draft PR for merging heat pump RTU control modules.

@JayHuLBL Can you please create a development branch for merging this branch? Thanks!

JayHuLBL · 2023-10-02T18:26:58Z

@karthikeyad-pnnl Please rebased the PR to the development branch issue3544_HeatPumpRTUControls.

JayHuLBL · 2023-10-30T18:30:30Z

@karthikeyad-pnnl
For the class Buildings.Controls.OBC.RooftopUnits.AuxiliaryCoil.AuxiliaryCoil, the documentation shows that "It then utilizes the heating coil valve position signal uHeaCoi as an auxiliary heating coil operation signal yAuxHea if uHeaCoi exceeds the heating coil valve signal threshold uThrHeaCoi with a hysteresis value dTHys." (I think the dTHys should be dUHys?). From the validation results showing below, the yAuxHea is greater than 0 before the uHeaCoi becomes greater than uThrHeaCoi + dTHys. Is it the expected behavior?

karthikeyad-pnnl · 2023-10-30T18:36:00Z

@JayHuLBL Hi Jianjun, that is correct. The first subplot shows the outdoor temperature TOut being lower than the lockout temperature TLocOut. Therefore, the controller is supposed to lock out the DX coils, and use the auxiliary heating coil to meet the heating load, because of which yAuxHea starts increasing immediately.

I will go through the documentation again to check the variable names again, and also add some more documentation to resolve any ambiguities.

JayHuLBL · 2023-10-30T18:40:25Z

@karthikeyad-pnnl Thanks. Then please update the documentation to avoid the misunderstanding.

JayHuLBL · 2023-11-27T18:15:09Z

@karthikeyad-pnnl Could you please update the documentation, then we can review and see if it can be merged?

Closes lbl-srg#3628

Closes lbl-srg#3631

…trols Issue3544 heat pump rtu controls

…nkewang001/modelica-buildings into issue3544_HeatPumpRTUControls

* Updated docker image to dymola 2024x

* Updated docker image to dymola 2024x * Updated reference results for Dymola 2024x

…3634) Bumps [jinja2](https://github.com/pallets/jinja) from 3.0.3 to 3.1.3. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@3.0.3...3.1.3) --- updated-dependencies: - dependency-name: jinja2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…oc (lbl-srg#3635) Bumps [jinja2](https://github.com/pallets/jinja) from 3.0.3 to 3.1.3. - [Release notes](https://github.com/pallets/jinja/releases) - [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst) - [Commits](pallets/jinja@3.0.3...3.1.3) --- updated-dependencies: - dependency-name: jinja2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update documentation about Spawn's warmup procedure The documentation was not been updated to reflect an enhancement to Spawn's warmup procedure. Specifically, a change was made to use wall temperatures instead of air temperature to exit warmup iteration. NatLabRockies/Spawn@ef91931 close lbl-srg#3176 * Corrected typo, replaced wall with surface temperature --------- Co-authored-by: Michael Wetter <mwetter@lbl.gov>

This increases the timeout for jenkins

This was removed by mistake in 0b1ebbd

* Prepared post-release files

* fixed typo * rebuild html

…ness (lbl-srg#4179) * Merged IBPSA with correction for kMeans and for wind cut-out speed * Merged IBPSA with correction to line thickness * Updated reference results

* updated the link * added revision note

* Merged IBPSA with correction for kMeans and for wind cut-out speed * Merged IBPSA with correction to line thickness * Fixes OMC issue #13800 (lbl-srg#4184) --------- Co-authored-by: Francesco Casella <francesco.casella@polimi.it>

Implemented auto-tuning PID controller.

…pRTUControls

karthikeyad-pnnl changed the base branch from master to issue3544_HeatPumpRTUControls October 3, 2023 21:03

dhblum and others added 24 commits January 8, 2024 10:05

Move borefield model

8097276

Correct typo in heating ETS

dda6836

Add issue #

2cf2705

Correct html

2d8980b

Fix removal of Plants.Reservoir

c33a8ad

Extend Plannts.Heating from VariantsPackage

aedc08c

Merge pull request lbl-srg#3629 from lbl-srg/issue3628_cleanDHC

d9c5cd3

Closes lbl-srg#3628

Removed file

349b749

Merge pull request lbl-srg#3632 from lbl-srg/issue3631_rmFile

c1005f5

Closes lbl-srg#3631

Uploading new module for determining next coil to be enabled

1111d15

Added documentation to new module

86fa821

Updated validation script and added new reference file.

e03293e

Integrated new block into main controller

0f046a3

Merge pull request #19 from karthikeyad-pnnl/issue3544_HeatPumpRTUCon…

1ffc03d

…trols Issue3544 heat pump rtu controls

Merge branch 'issue3544_HeatPumpRTUControls' of https://github.com/ju…

81cfcb5

…nkewang001/modelica-buildings into issue3544_HeatPumpRTUControls

Unit tests after adding NextCoil module

105a8fc

Updated documentation

178a9d9

Updated docker image to dymola 2024x (lbl-srg#3623)

8657ec1

* Updated docker image to dymola 2024x

Update conf.yml for OpenModelica 1.22.1 (lbl-srg#3621)

1573d48

* Updated docker image to dymola 2024x * Updated reference results for Dymola 2024x

Added curves for auxiliary coil validation model and rerun unit test

2e4f554

Corrected typo (lbl-srg#3645)

9c5d528

mwetter and others added 30 commits March 12, 2025 07:28

Corrected annotation

8ad25b9

Master branch, increase timeout (lbl-srg#4146)

2711d1d

This increases the timeout for jenkins

Increased timeout

916d340

Updated path to relative directory

9569ff4

Merge branch 'master' into issue4149_obsolete

141f360

Merge branch 'ibpsa1989_fixWAMAKLink'

3c8bfd6

Merge branch 'master' into IBPSASync_issue1987_missingSemicolon

67b17a0

Merge branch 'master' into issue4149_obsolete

c53dee6

Updated package.order

1f38dab

Updated release notes and date

868a858

Updated release notes and date

28fde80

Added release notes of previous versions

a9503d6

Merged IBPSA master with update to modular heat pump

ca276a9

Updated BuildingsPy to v5.2.0

1771249

Merge branch 'issue4149_obsolete' into issue4153_releasePrep

2cd2403

Added conversion entry that was mistakenly removed [ci skip]

2594cb2

This was removed by mistake in 0b1ebbd

Corrected condition for spawn binary installations

6794bb3

Updated versions and directories for Spawn testing

87dac29

Merge branch 'issue4149_obsolete' into issue4153_releasePrep

a5078eb

Increased timeout

a192df3

Merge branch 'issue4149_obsolete' into issue4153_releasePrep

11e6a6f

Added files to exclude list

ff06eed

Corrected typo in release notes

20754a3

Add files for developments past version 12.0.0 (lbl-srg#4166)

4175de9

* Prepared post-release files

fixed typo (lbl-srg#4173)

e2b490a

* fixed typo * rebuild html

IBPSA Sync - wind cut off power, kMeans for borefield, and line thick…

97f14e6

…ness (lbl-srg#4179) * Merged IBPSA with correction for kMeans and for wind cut-out speed * Merged IBPSA with correction to line thickness * Updated reference results

Updated reference link to the climate constant (lbl-srg#4187)

0dc21f2

* updated the link * added revision note

Issue4183 damper example (lbl-srg#4185)

534ab35

* Merged IBPSA with correction for kMeans and for wind cut-out speed * Merged IBPSA with correction to line thickness * Fixes OMC issue #13800 (lbl-srg#4184) --------- Co-authored-by: Francesco Casella <francesco.casella@polimi.it>

Issue2884 pid autotuning (lbl-srg#2957)

a15d21d

Implemented auto-tuning PID controller.

Merge remote-tracking branch 'upstream/master' into issue3544_HeatPum…

feee8eb

…pRTUControls

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue3544 heat pump rtu controls#3545

Issue3544 heat pump rtu controls#3545
karthikeyad-pnnl wants to merge 561 commits intolbl-srg:issue3544_HeatPumpRTUControlsfrom
karthikeyad-pnnl:issue3544_HeatPumpRTUControls

karthikeyad-pnnl commented Oct 1, 2023

Uh oh!

JayHuLBL commented Oct 2, 2023

Uh oh!

JayHuLBL commented Oct 30, 2023 •

edited

Loading

Uh oh!

karthikeyad-pnnl commented Oct 30, 2023

Uh oh!

JayHuLBL commented Oct 30, 2023

Uh oh!

JayHuLBL commented Nov 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Conversation

karthikeyad-pnnl commented Oct 1, 2023

Uh oh!

JayHuLBL commented Oct 2, 2023

Uh oh!

JayHuLBL commented Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

karthikeyad-pnnl commented Oct 30, 2023

Uh oh!

JayHuLBL commented Oct 30, 2023

Uh oh!

JayHuLBL commented Nov 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

JayHuLBL commented Oct 30, 2023 •

edited

Loading