Open
Conversation
Contributor
Author
|
@EttoreZ Would you please take another look at the changes? |
Contributor
|
Hey @JayHuLBL just two quick comments:
|
Contributor
Author
|
The CI test of the TOUGH coupling example model failed to run, as it uses the Python interface function which now requires Python 3.8. However, current Dymola docker container image does not support Python 3.8, see below comments in master branch: We would be able to run the example models, after merging the PR #4493. |
JayHuLBL
commented
Mar 24, 2026
| equation | ||
| // Delete the TOUGH temporary working folder | ||
| // Note that the working folder path is specified in the Python function. | ||
| when {terminal()} then |
Contributor
Author
There was a problem hiding this comment.
The terminal() function is not supported by Optimica 1.66.
The function is also being used in Buildings.DHC.Loads.HotWater.ThermostaticMixingValve. Running the model Buildings.DHC.Loads.HotWater.Examples.StorageTankWithExternalHeatExchanger with Optimica 1.66, we can see
In component theMixVal:
The terminal() operator is not supported, and is currently evaluated to false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.