Skip to content

Add Modelica Tough coupling user guide#3696

Open
JayHuLBL wants to merge 96 commits intomasterfrom
issue1495_clean_Mo2To_Interface
Open

Add Modelica Tough coupling user guide#3696
JayHuLBL wants to merge 96 commits intomasterfrom
issue1495_clean_Mo2To_Interface

Conversation

@JayHuLBL
Copy link
Copy Markdown
Contributor

No description provided.

@JayHuLBL JayHuLBL self-assigned this Mar 11, 2024
@JayHuLBL
Copy link
Copy Markdown
Contributor Author

@EttoreZ Would you please take another look at the changes?

@EttoreZ
Copy link
Copy Markdown
Contributor

EttoreZ commented Mar 11, 2024

Hey @JayHuLBL just two quick comments:

  • In the doStep description of the UserGuide. I would comment/remove this line: os.system("./writeincon < writeincon.inp") and uncomment this line # write_incon(), and also remove this line os.system(" ./readsave < readsave.inp > out.txt") and uncomment this line # readsave(). This is because the Python script now does not rely on the Fortran utility programs anymore.
  • The second comment is also related to that. In the diagram where you show the workflow of the Python script, writeincon and readsave are cited as utility programs. I would change that to Python functions.
    Apart from those, everything else looks good to me.

@JayHuLBL
Copy link
Copy Markdown
Contributor Author

The CI test of the TOUGH coupling example model failed to run, as it uses the Python interface function which now requires Python 3.8. However, current Dymola docker container image does not support Python 3.8, see below comments in master branch:

comment: Python 3.8 not available in docker image

We would be able to run the example models, after merging the PR #4493.

equation
// Delete the TOUGH temporary working folder
// Note that the working folder path is specified in the Python function.
when {terminal()} then
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The terminal() function is not supported by Optimica 1.66.

The function is also being used in Buildings.DHC.Loads.HotWater.ThermostaticMixingValve. Running the model Buildings.DHC.Loads.HotWater.Examples.StorageTankWithExternalHeatExchanger with Optimica 1.66, we can see

In component theMixVal:
    The terminal() operator is not supported, and is currently evaluated to false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants