Merging air-cleaning models into issue branch issue3720_air_cleaning.#3753
Open
caryfaulknerPNNL wants to merge 14 commits intolbl-srg:issue3720_air_cleaningfrom
Open
Merging air-cleaning models into issue branch issue3720_air_cleaning.#3753caryfaulknerPNNL wants to merge 14 commits intolbl-srg:issue3720_air_cleaningfrom
caryfaulknerPNNL wants to merge 14 commits intolbl-srg:issue3720_air_cleaningfrom
Conversation
This merges IBPSA 1853
* Added insulation to idf file and resized system * Added insulation and resized heating system
* Corrected wrong annotation * Updated copyright year * Corrected user guide
* merged from ibpsa
This merges IBPSA, issue1855_aquifer_documentation
* Rename models * Converted DHC user guide to model instead of package * Added missing link to userguide --------- Co-authored-by: David Blum <dhblum@lbl.gov> Co-authored-by: Michael Wetter <mwetter@lbl.gov>
* Changed sensor configuration to avoid warning For lbl-srg#3731
JayHuLBL
reviewed
Mar 29, 2024
| defaultComponentName="res", | ||
| Documentation(info="<html> | ||
| <p>Partial model for duct GUV.</p> | ||
| </html>", revisions="<html> |
Contributor
There was a problem hiding this comment.
It should be a new revision record.
JayHuLBL
reviewed
Mar 29, 2024
| @@ -0,0 +1,649 @@ | |||
| within Buildings.AirCleaning; | |||
| package BaseClasses | |||
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to merge the air cleaning package into this issue branch for LBNL's review. This package includes three base models: DuctGUV.mo, PAC.mo, and RoomGUV.mo, as well as base classes and examples related to those three models.