Templates • Refactor AWHP plant template with modular HP model#4171
Merged
Templates • Refactor AWHP plant template with modular HP model#4171
Conversation
…uildings into issue4152_HpTemplateWithModular
…ssue4169_loadDepHpChillerModels
…/modelica-buildings into issue4152_HpTemplateWithModular
…/modelica-buildings into issue4152_HpTemplateWithModular
…/modelica-buildings
- This is due to an error when reading the reference results. - Removing the data reader makes the models supported by OMC.
…/modelica-buildings [ci skip]
- Exclude model from CI tests with OMC.
…/modelica-buildings [ci skip]
- The description of the parameters for the design CHW/HW and source temperature has been updated. - The documentation of the core block has been improved. - The parameter P_min is now declared as SI.Power. - The input connector TSet has been moved to avoid overlap with ySet. - The description of the input connectors on, hea and coo has been clarified.
…/modelica-buildings into issue4152_HpTemplateWithModular
- Replace source by ambient for compatibility with cooling cycles.
…/modelica-buildings [ci skip]
…ssue4152_HpTemplateWithModular
Some plant configurations fail to simulate with Radau: see https://app.travis-ci.com/github/lbl-srg/modelica-buildings/jobs/634894041
Contributor
Author
|
@mwetter @JayHuLBL This is ready for review. Note that I changed the solver from Radau to Cvode in the validation script |
Member
|
@AntoineGautier I think the change from Radau to CVode was because for Optimica, we also use CVode. But if Radau works better with Dymola for these models, then I see no issues with using Radau. |
mwetter
approved these changes
Sep 26, 2025
…ssue4152_HpTemplateWithModular
AntoineGautier
force-pushed
the
issue4152_HpTemplateWithModular
branch
from
d1bcc28 to
489a43a
Compare
AntoineGautier
force-pushed
the
issue4152_HpTemplateWithModular
branch
from
489a43a to
f97113a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #4152.
TODO before merging:
issue4152_HpTemplateWithModularFailed to evaluate and check the size declaration of pla.hp.dat.perHeaHp.PLRSor