Replace fluid pass-through with fixed resistance in actuators#4228
Merged
Replace fluid pass-through with fixed resistance in actuators#4228
Conversation
AntoineGautier
force-pushed
the
issue4227_fixedResistanceActuators
branch
from
7b744e8 to
fc879c0
Compare
…ssue4227_fixedResistanceActuators
AntoineGautier
force-pushed
the
issue4227_fixedResistanceActuators
branch
from
88d6012 to
bb83c70
Compare
Member
|
@AntoineGautier : Is this ready to merge or more work needed from your end? I plan to bump the version number to 12.1.0, so merging this before will avoid a merge conflict. |
Contributor
Author
|
Yes, ready to merge on my end. |
mwetter
added a commit
that referenced
this pull request
May 17, 2025
* fixed typo (#4173) * IBPSA Sync - wind cut off power, kMeans for borefield, and line thickness (#4179) * Merged IBPSA with correction to line thickness * Updated reference link to the climate constant (#4187) * Issue4183 damper example (#4185) * Fixes OMC issue #13800 (#4184) --------- Co-authored-by: Francesco Casella <francesco.casella@polimi.it> * Issue2884 pid autotuning (#2957) Implemented auto-tuning PID controller. * Updated conversion script to remove clear commands (#4202) For #4200 * Add missing header files and correct type comparison in Utilities.Plotter (#4211) * Added missing header files For #4209 and #4210 * Corrected comparison of boolean with real * Reformulated function to avoid binding equation not a parameter expression warning For 4215 * Reformulated function to avoid binding equation not a parameter expression warning (#4216) For 4215 * Guarded against rounding error for wind cutoff (#4229) This is for #4224 * Correct error in UA_nominal calculation of Merkel cooling tower (#4226) * Changed UA_nominal calculation. Added validation model For #4189 --------- Co-authored-by: Katy Hinkelman <44682485+khinkelman@users.noreply.github.com> * Update FMI library (#4207) * Update CMakeLists.txt for FMIL3 (#4198) * Built fmi library * Generated binaries and Windows and Linux * Updated revision notes --------- Co-authored-by: Robin Andersson <robin.andersson@modelon.com> * Corrected wrong type comparison (#4235) For #4233 * Update dymola image (#4239) This updates the docker image. * Replace fluid pass-through with fixed resistance in actuators (#4228) * Replace fluid pass-through with fixed resistance in actuators * Fix for ambiguous argument 'origin/master' --------- Co-authored-by: Jianjun Hu <JianjunHu@lbl.gov> Co-authored-by: Francesco Casella <francesco.casella@polimi.it> Co-authored-by: Katy Hinkelman <44682485+khinkelman@users.noreply.github.com> Co-authored-by: Robin Andersson <robin.andersson@modelon.com> Co-authored-by: Antoine Gautier <agautier@solamen.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for #4227.
Note that with this PR, the parameter
m_flow_nominalneeds to be assigned a non-zero value (via the parameter record) even if the damper or valve type is set toNone. Previously, this parameter could be left unassigned (since it was declared with astartattribute and aDialog(enable=false)annotation).This is not seen as an issue for the template development because a default value can always be provided as in:
https://github.com/lbl-srg/modelica-buildings/blob/master/Buildings/Templates/AirHandlersFans/Data/VAVMultiZone.mo#L38-L45
or:
30ec283#diff-acd47242c40cc65fce0b368f54ca2b640e80b9ca5774dab11288ae2bd81cb934
In the equipment schedule page of ctrl-flow (to be developed), the whole parameter record is disabled if the type is
None, which should prevent requesting a value form_flow_nominal.