Conversation
…uildings into issue4152_HpTemplateWithModular
…ssue4169_loadDepHpChillerModels
- This is due to an error when reading the reference results. - Removing the data reader makes the models supported by OMC.
- Exclude model from CI tests with OMC.
- The description of the parameters for the design CHW/HW and source temperature has been updated. - The documentation of the core block has been improved. - The parameter P_min is now declared as SI.Power. - The input connector TSet has been moved to avoid overlap with ySet. - The description of the input connectors on, hea and coo has been clarified.
- Replace source by ambient for compatibility with cooling cycles.
- This allows modeling a minimum stage runtime. - (Otherwise when clause gets included in algebraic loop.)
- Plus minor updates to the documentation.
Contributor
Author
|
@karthikeyad-pnnl FYI, this is the PR with the new 4-pipe HP model. |
- Note that the models can be translated and simulated with OMC 1.25.1.
AntoineGautier
force-pushed
the
issue4283_multiPipeHp
branch
from
a7fb51c to
cc83ab6
Compare
…ssue4283_multiPipeHp
AntoineGautier
force-pushed
the
issue4283_multiPipeHp
branch
from
5efa17f to
0613204
Compare
Contributor
Author
Contributor
|
@mwetter @AntoineGautier I think it is good to merge. |
mwetter
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #4283. (See the issue page for the main requirements.)
The main model is
Buildings.Fluid.HeatPumps.ModularReversible.TableData2DLoadDepSHC.The core implementation is in
Buildings.Fluid.HeatPumps.ModularReversible.RefrigerantCycle.BaseClasses.TableData2DLoadDepSHC.TODO before merging:
Notes:
Buildings.Fluid.HeatPumps.ModularReversible.Examples.TableData2DLoadDepSHC1And2andBuildings.Fluid.HeatPumps.ModularReversible.Examples.TableData2DLoadDepSHC1Onlycannot be translated with OMC 1.24.0-1 (version used in https://github.com/lbl-srg/modelica-buildings/blob/master/.travis.yml#L35). However, they can be translated and simulated with version 1.25.1.