Skip to content

Issue3284 district chp#4293

Draft
JayHuLBL wants to merge 65 commits intomasterfrom
issue3284_districtCHP
Draft

Issue3284 district chp#4293
JayHuLBL wants to merge 65 commits intomasterfrom
issue3284_districtCHP

Conversation

@JayHuLBL
Copy link
Copy Markdown
Contributor

No description provided.

ZhanweiHe and others added 16 commits November 17, 2024 10:11
This is a package for the CHP model applied in district energy system. In the package, here are: ToppingCycle, BottomingCycle, Combined, Data, BaseClasses, Validation, and Obsolete.
…ation.ToppingCycle, DistrictCHP.Validation.BottomingCycle_AnnualSim, and DistrictCHP.Examples.CombinedCycleCHP. 2) Updated package icons
Added .mos files for the districtCHP package.
Delete package Buildings.Fluid.CHPs.DistrictCHP.Obsolete and ensure a…
</ul>
</html>", info="<html>
<p>
This validation model compares the proposed CHP bottoming-cycle model with the
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZhanweiHe The documentation should be updated. The validation is not comparing the results with the one from TPL.

Copy link
Copy Markdown

@ZhanweiHe ZhanweiHe Jul 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add two figures (the comparison with TPL) to the documentation

Comment thread Buildings/Fluid/CHPs/DistrictCHP/Validation/TopCycle.mo Outdated
Comment thread Buildings/Fluid/CHPs/DistrictCHP/package.mo Outdated
Copy link
Copy Markdown
Contributor Author

@JayHuLBL JayHuLBL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZhanweiHe See inline comments

…ocumentation 2)add two figures (the comparison with TPL) to the documentation of the bottoming cycle validation model
…ackage documentation 2)add two figures (the comparison with TPL) to the documentation of the bottoming cycle validation model
…ackage documentation 2)add two figures (the comparison with TPL) to the documentation of the bottoming cycle validation model"

This reverts commit 49403a8.

B
1) Add system schematics and the governing equations to the package documentation 2)add two figures (the comparison with TPL) to the documentation of the bottoming cycle validation model
@ZhanweiHe
Copy link
Copy Markdown

@ZhanweiHe See inline comments
@JayHuLBL , I have included all the changes in this PR: 4297

equation
//Waste heat specific enthalpy calculation
// Avaeraged specific heat of exhaust is 1.08 kJ/(kg-K)
hWasHea = 1.08e3*(TExh - TAmb);
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does the 1.08e3 come from? Do you have a reference?

Copy link
Copy Markdown

@ZhanweiHe ZhanweiHe Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JayHuLBL The specific heat of exhaust gas is dependent on its temperature, and users can use the known exhaust temperature to estimate the specific heat of exhaust in a specific gas turbine engine. Here is a table can be used Flue gases properties table

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you be more specific of how the 1.08e3 being calculated? In the Modelica model, it says Averaged specific heat of exhaust is 1.08 kJ/9kg.K). Then how was the average value calculated? The table (https://www.pipeflowcalculations.com/tables/flue-gas.xhtml) shows that the 1.08 is between the status of temperature between 100 degC and 200 degC.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ViswanathanGanesh01 Could you please let me know if there is any comments on this?


package SolarTurbines "Solar Turbines data sheets"

package NaturalGas "The fuel used is natural gas"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZhanweiHe @ViswanathanGanesh01 Do we have reference on these performance data? where are they from?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JayHuLBL , this data was obtained from a faculty here at Penn State. We do not have a reference link for the public available data.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MBL will have the copyright to the data, if there is no reference. Will it be an issue?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check regarding this and get back to you soon!

@JayHuLBL
Copy link
Copy Markdown
Contributor Author

@ZhanweiHe @ViswanathanGanesh01

The Buildings.Fluid.CHPs.DistrictCHP.Validation.BottomCycle and Buildings.Fluid.CHPs.DistrictCHP.Examples.Combined failed to run with OpenModelica, with errors as below:
Screenshot 2025-12-19 at 11 21 20 AM

With Dymola, running the unit test for package Buildings.Fluid.CHPs.DistrictCHP gives following warning:
Screenshot 2025-12-19 at 11 20 19 AM

The errors and warnings are related the water feeding pump in the bottom cycle. Why do we use the model Modelica.Fluid.Machines.ControlledPump, rather than the Buildings.Fluid.Movers.FlowControlled_m_flow? I created the test model BottomCycle_test by replacing the pump instance with the pump model from MBL. Both warnings and errors are gone.

Please check if the changes are good to you.

@ViswanathanGanesh01
Copy link
Copy Markdown

ViswanathanGanesh01 commented Dec 23, 2025

@ZhanweiHe @ViswanathanGanesh01

The Buildings.Fluid.CHPs.DistrictCHP.Validation.BottomCycle and Buildings.Fluid.CHPs.DistrictCHP.Examples.Combined failed to run with OpenModelica, with errors as below: Screenshot 2025-12-19 at 11 21 20 AM

With Dymola, running the unit test for package Buildings.Fluid.CHPs.DistrictCHP gives following warning: Screenshot 2025-12-19 at 11 20 19 AM

The errors and warnings are related the water feeding pump in the bottom cycle. Why do we use the model Modelica.Fluid.Machines.ControlledPump, rather than the Buildings.Fluid.Movers.FlowControlled_m_flow? I created the test model BottomCycle_test by replacing the pump instance with the pump model from MBL. Both warnings and errors are gone.

Please check if the changes are good to you.

This looks good! @JayHuLBL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants