Issue4304 hybrid air source heat pump plant controls#4490
Open
karthikeyad-pnnl wants to merge 112 commits intolbl-srg:issue4304_HybridAirSourceHeatPumpControlsfrom
Open
Conversation
improved ill-posed integer rounding
Upgrade Python interaface to 3.12
- Also add nZon to configuration record.
…ca_1_66 Update Modelica dependency to 4.1.0 and update Optimica image to 1.66
…nstance of non-CDL block usage
…ssue4497_fixClassMod
…es from single-operation mode to dual-operation mode. Updated Boolean enable conditions on routing blocks to use correct signals for pump enable
…sed-loop validation model for hybrid plant
Corrected type specification for g-function
Move zoning parameter declarations into controller record
Avoided unsafe array access that relied on short-circuiting
Removed redundant not init() condition
…dates to flow sizing to resolve simulation issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@AntoineGautier I am submitting this to resolve the comments on #4369