Conversation
Contributor
Author
|
@mwetter It's ready for your review. |
mwetter
reviewed
May 6, 2026
| y); | ||
| } | ||
|
|
||
| /* Track freed objects to prevent double-free when OpenModelica calls the |
Member
There was a problem hiding this comment.
@JayHuLBL : If the root cause is indeed multiple calls to free, why not simply setting the pointer to NULL as is recommended at https://cmu-sei.github.io/secure-coding-standards/sei-cert-c-coding-standard/recommendations/memory-management-mem/mem01-c/
This seems much clearer than the rather convoluted tracking mechanism that this pull request would introduce.
Contributor
Author
There was a problem hiding this comment.
@mwetter
OpenModelica stores the external object pointer in its own runtime and then passes the same (now-freed) address again on the second destructor call.
Setting a local variable to NULL after free has no effect on that external stored value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #3345.