Set overhead variable #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidstrauss
requested changes
Oct 11, 2016
Member
davidstrauss
left a comment
davidstrauss
left a comment
There was a problem hiding this comment.
Yes, it's somewhat arbitrary. We should probably make it configurable, though only manually (non-GUI).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In merging github and drupal.org repos yesterday I lost this change that @davidstrauss made on drupal.org. It uses some light machine learning that was added to LCache in lcache/lcache#24
@davidstrauss, it seems like this argument should be configurable to some degree, perhaps making it an argument to the service,
cache.backend.lcache. The vast, vast majority of people using the module won't need to know that configurability is there. But it's a number we could tweak to find optimal performance.100is a somewhat arbitrary choice here, yes?