Skip to content

Support Symfony 8 and bump doctrine dependencies #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acrobat wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support Symfony 8 and bump doctrine dependencies #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,34 @@ jobs:
strategy:
fail-fast: false
matrix:
php: [8.1, 8.2, 8.3]
symfony: [6.4.*, 7.0.*]
phpunit: [^9.0, ^10.0, ^11.0]
php: [8.1, 8.2, 8.3, 8.4]
symfony: [6.4.*, 7.3.*, 8.0.*]
phpunit: [^10.0, ^11.0]
php-matcher: [^6.0]
orm: [^2.5, ^3.0]
exclude:
- php: 8.1
symfony: 7.0.*
symfony: 7.3.*
- php: 8.1
phpunit: ^11.0
- php: 8.1
symfony: 8.0.*
- php: 8.2
symfony: 8.0.*
- php: 8.3
symfony: 8.0.*
- php: 8.1
symfony: 8.0.*
orm: ^2.5
- php: 8.2
symfony: 8.0.*
orm: ^2.5
- php: 8.3
symfony: 8.0.*
orm: ^2.5
- php: 8.4
symfony: 8.0.*
orm: ^2.5

steps:
- uses: "actions/checkout@v4"
Expand Down
16 changes: 8 additions & 8 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,26 +24,26 @@
}
],
"require": {
"php": "^8.0",
"php": "^8.1",
"ext-json": "*",

"coduo/php-matcher": "^6.0",
"openlss/lib-array2xml": "^1.0",
"doctrine/data-fixtures": "^1.2",
"doctrine/doctrine-bundle": "^2.0",
"doctrine/data-fixtures": "^2.1",
"doctrine/doctrine-bundle": "^2.0 || ^3.0",
"doctrine/orm": "^2.5 || ^3.0",
"nelmio/alice": "^3.6",
"phpspec/php-diff": "^1.1",
"phpunit/phpunit": "^9.0 || ^10.0 || ^11.0",
"symfony/browser-kit": "^6.4 || ^7.0",
"symfony/finder": "^6.4 || ^7.0",
"symfony/framework-bundle": "^6.4 || ^7.0",
"phpunit/phpunit": "^10.0 || ^11.0",
"symfony/browser-kit": "^6.4 || ^7.3 || ^8.0",
"symfony/finder": "^6.4 || ^7.3 || ^8.0",
"symfony/framework-bundle": "^6.4 || ^7.3 || ^8.0",
"theofidry/alice-data-fixtures": "^1.0"
},
"require-dev": {
"phpstan/phpstan-strict-rules": "^1.0",
"phpstan/phpstan-webmozart-assert": "^1.0",
"symfony/serializer": "^5.4 || ^6.0",
"symfony/serializer": "^6.4 || ^7.3 || ^8.0",
"phpstan/phpstan": "^1.8"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion test/app/AppKernel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public function getProjectDir(): string
/**
* {@inheritdoc}
*/
public function registerContainerConfiguration(LoaderInterface $loader)
public function registerContainerConfiguration(LoaderInterface $loader): void
{
$loader->load(static function (ContainerBuilder $container): void {
$container->loadFromExtension('framework', [
Expand Down
4 changes: 2 additions & 2 deletions test/src/Controller/SampleController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,10 @@ public function categoryIndexAction(Request $request): Response
return $this->respond($request, $categories);
}

public function showAction(Request $request): Response
public function showAction(Request $request, int $id): Response
{
$productRepository = $this->objectManager->getRepository(Product::class);
$product = $productRepository->find($request->get('id'));
$product = $productRepository->find($id);

if (!$product) {
throw new NotFoundHttpException();
Expand Down
Loading