Add support for PHPUnit 12 #203
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rafikooo
force-pushed
the
feature/phpunit-12-support
branch
10 times, most recently
from
8142bad to
68ea82f
Compare
Rafikooo
force-pushed
the
feature/phpunit-12-support
branch
2 times, most recently
from
d5d094a to
9b6364c
Compare
Rafikooo
force-pushed
the
feature/phpunit-12-support
branch
from
9b6364c to
36fd034
Compare
jakubtobiasz
requested changes
Dec 10, 2025
| fail-fast: false | ||
| matrix: | ||
| php: [8.1, 8.2, 8.3] | ||
| php: [8.3] |
Collaborator
There was a problem hiding this comment.
PHPUnit 10 supports PHP ^8.1, so we should leave it in the matrix. For PHP <8.3 we should add an exclude in combination with PHPUnit 12.
| * @before | ||
| */ | ||
| public function setUpClient(): void | ||
| protected function setUp(): void |
Collaborator
There was a problem hiding this comment.
Why did you need to replace the before and after class? As we extend the ApiTestCase we need to remember about calling the parent's setUp once we override in a deriving class.
| "nelmio/alice": "^3.6", | ||
| "phpspec/php-diff": "^1.1", | ||
| "phpunit/phpunit": "^9.0 || ^10.0 || ^11.0", | ||
| "phpunit/phpunit": "^9.0 || ^10.0 || ^11.0 || ^12.0", |
Collaborator
There was a problem hiding this comment.
In theory you dropped ^9.0, but you left it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
^12.0tophpunit/phpunitversion constraint incomposer.json@dataProviderannotation to#[DataProvider]attribute@before/@beforeClass/@afterClassannotations with standardsetUp()method$sharedKernel,createSharedKernel,ensureSharedKernelShutdown)setUpClient(),createMatcher(),setUpDatabase()into singlesetUp()methodJsonApiTestCaseandXmlApiTestCaseto usesetServerParameter()instead of recreating clientSampleControllerto handle nullAcceptheader (test fixture)