Skip to content

Conversation

@jwnimmer-tri
Copy link
Contributor

Fix suppressions to avoid Clang complaints about unknown flags.

Add missing suppressions to lcm-logger.

Fix suppressions to avoid Clang complaints about unknown flags.

Add missing suppressions to lcm-logger.
Copy link
Contributor

@nosracd nosracd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how much it matters, but it looks like the example is building with an unused variable warning. Would it make sense to disable compiler warnings in the example as well?

Overall no objections to these changes, ready to merge whenever

@jwnimmer-tri
Copy link
Contributor Author

jwnimmer-tri commented Oct 6, 2025

... it looks like the example is building with an unused variable warning. Would it make sense to disable compiler warnings in the example as well?

Yes, I can confirm that I see the warning, too.

Adding the warning suppression would not be able to inherit the copts from load("//lcm-bazel/private:copts.bzl", "WARNINGS_COPTS") (they are "private") so it would be repeating the information here again.

Instead of that, I would rather fix lcm-gen to not emit unused variables in the first place. Then, all projects can avoid the need to add the warning suppression.

@nosracd nosracd merged commit 309778a into lcm-proj:master Oct 9, 2025
66 checks passed
@jwnimmer-tri jwnimmer-tri deleted the bazel-warnings branch October 9, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants