Block-level scoping (#92) and variable manager (#88) #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morganthomas
force-pushed
the
morgan/88c-rebase-rebase-rebase
branch
from
38d2144 to
76fcb53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #92
Closes #88
These changes do not affect the memory usage or the number of cycles for the XMSS aggregation program as tested with
RUSTFLAGS='-C target-cpu=native' cargo run --release -- xmss --n-signatures 1775.For the WHIR recursion program as tested with
RUSTFLAGS='-C target-cpu=native' cargo run --release -- recursion --count 8, these changes cause:I saw no significant impact on proving time for either XMSS or WHIR recursion. With these changes, there is some tradeoff available between memory usage and number of cycles, so we can explore how to adjust this tradeoff to get better proving time.