Use HttpMultiServer and Ktor for handling raw HTTP requests #2645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszwojtczak
requested review from
fylyppo,
gogolon,
pdenert and
piotruela
as code owners
|
To view this pull requests documentation preview, visit the following URL: docs.page/leancodepl/patrol~2645 Documentation is deployed and generated using docs.page. |
github-actions
bot
added
the
package: patrol
mateuszwojtczak
force-pushed
the
hotfix/http-multi-server
branch
2 times, most recently
from
5423410 to
ed5d24f
Compare
Collaborator
|
Will this close this one? #2317 |
github-actions
bot
added
the
package: patrol_cli
jBorkowska
force-pushed
the
hotfix/http-multi-server
branch
2 times, most recently
from
ed5d24f to
460895b
Compare
jBorkowska
force-pushed
the
hotfix/http-multi-server
branch
from
460895b to
f551276
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using raw HTTP instead of HTTPS by our localhost communication. Because of that, we sometimes have trouble with OkHttp blocking our requests due to Android clear-text traffic policies.
To fix that issue on some device farms (e.g. Browserstack), this PR uses Ktor for raw HTTP communication. It also introduces HttpMultiServer package for cases where there are multiple network interfaces (e.g. BrowserStack again 🤣 ) and we don't know which to arbitrarily choose.