feat: coding functions for Fin
#1332
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jul 19, 2025
Collaborator
|
Mathlib CI status (docs):
|
Collaborator
Author
|
This PR is split from #1007 to avoid Mathlib issues discussed there. |
kim-em
reviewed
Aug 8, 2025
kim-em
reviewed
Aug 8, 2025
kim-em
reviewed
Aug 8, 2025
Collaborator
|
The coding part looks fine. |
Contributor
|
It does not code a finite type (so you might consider it out of scope), but finSumNatEquiv in Mathlib feels thematically very similar to many of your encodings here, and feels similarly like the sort of thing one might find useful absent a mathematical context. |
Collaborator
Author
|
There's another plan for that but thanks for reminding me! |
fgdorais
added
WIP
Collaborator
Author
|
Back into development to fix outstanding issues and other stuff. |
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
leanprover-community-mathlib4-bot
added
the
merge-conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functions for coding common finite types into
Fin.Depends on:
Fin.sum,Fin.prod,Fin.countP#1460