Skip to content

chore: misc. improvements to runLinter tracing #1599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fgdorais merged 5 commits into from
Jan 6, 2026
Merged

chore: misc. improvements to runLinter tracing #1599

fgdorais merged 5 commits into from
Jan 6, 2026
+23 −5

Conversation

@thorimur
Copy link
Contributor

@thorimur thorimur commented Jan 5, 2026 •
edited
Loading

This PR:

  • updates the Usage: message for runLinter to include the --trace and --no-build flags, and adds some documentation
  • uses eprintln instead of println when throwing when --no-build is set
  • references the current module in top-level IO.println trace messages in runLinterOnModule (this is already done via traceLint in CoreM)
  • improves the message for linter failures during runLinter by disclaiming that it may include nolints
  • summarizes nolints.json to help explain potential failures

@github-actions github-actions bot added the awaiting-review This PR is ready for review; the author thinks it is ready to be merged. label Jan 5, 2026
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Jan 5, 2026
@leanprover-community-mathlib4-bot
Update Batteries branch for testing leanprover-community/batteries#1599
87e3921
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Jan 5, 2026

Mathlib CI status (docs):

@fgdorais fgdorais added this pull request to the merge queue Jan 6, 2026
Merged via the queue into leanprover-community:main with commit ac7af86 Jan 6, 2026
1 check passed
@github-actions github-actions bot removed the awaiting-review This PR is ready for review; the author thinks it is ready to be merged. label Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fgdorais fgdorais fgdorais approved these changes

Assignees

No one assigned

Labels

builds-mathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thorimur @leanprover-community-bot @fgdorais