-
Notifications
You must be signed in to change notification settings - Fork 131
[WIP] Verification of binary heap #1602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cmlsharp
wants to merge
13
commits into
leanprover-community:main
Choose a base branch
from
cmlsharp:binomial_heap
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+503
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
WIP |
6c31ff8 to
715dfcf
Compare
Contributor
Author
|
(I will say, I'm currently overusing grind so compilation is slow at the moment) |
cbc532d to
67b5f2b
Compare
Collaborator
|
Please merge main to clarify API changes. |
3dc2b22 to
c806990
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jan 7, 2026
Collaborator
|
Mathlib CI status (docs):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is still a work in progress, but I wanted to get it out there.
This PR begins the process of addressing #1442. Thus far I have managed to prove that
heapifyDown,heapifyUp, andmkHeappreserve the binary heap correctness property, These should be the lions share of the difficulty, as the remaining operations are largely wrappers around the former two.As suggested in that thread, this PR also alters the definition of
BinaryHeapto use anOrdinstance on the contained type rather than a comparison function. The proofs additionally rely onStd.OrientedOrdandStd.TransOrd.The core correctness property is encoded as:
However, for proving
heapifyUpit was more convenient to use a "bottom up" version of a correctness propertyI provide a theorem that
WFis equivalent toWF.bottomUp.