feat: Add C strdup() #112
Merged
feat: Add C strdup() #112
+49
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: make allocation failures fatal (see conversion [here](leanprover#99 (comment))). Now alloc(), strdup(), and strndup() will all abort if memory allocation fails. But add new try_alloc() function that may still return NULL, if we find we want to try and handle Out of Memory in specific circumstances where we might actually expect it (e.g. allocating an arbitrarily sized buffer)
govereau
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, make allocation failures fatal (see conversion here).
region_alloc(),region_strdup(), andregion_strndup()will all abort the program if memory allocation fails. But I added a newregion_try_alloc()function, that may still return NULL, if we find we want to try and handle Out of Memory in specific circumstances where we might actually expect it (e.g. allocating an arbitrarily sized buffer)