Skip to content

feat: "try this" messages with support for interactivity #10524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhuisi merged 4 commits into from
Oct 13, 2025
Merged

feat: "try this" messages with support for interactivity #10524

mhuisi merged 4 commits into from
Oct 13, 2025

Conversation

@mhuisi
Copy link
Contributor

@mhuisi mhuisi commented Sep 23, 2025

This PR adds support for interactivity to the combined "try this" messages that were introduced in #9966. In doing so, it moves the link to apply a suggestion to a separate [apply] button in front of the suggestion. Hints with diffs remain unchanged, as they did not previously support interacting with terms in the diff, either.

Suggestion with interactive message

@mhuisi mhuisi requested a review from digama0 as a code owner September 23, 2025 15:50
@mhuisi mhuisi added the changelog-server Language server, widgets, and IDE extensions label Sep 23, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 23, 2025
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Sep 23, 2025 •
edited
Loading

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-09-22 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-09-23 16:42:06)
  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-10-01 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-10-01 16:07:16)
  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-10-10 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-10-11 12:20:26)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 23, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10524
d3792d1
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Sep 23, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10524
6285336
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Sep 23, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Sep 23, 2025 •
edited
Loading

Mathlib CI status (docs):

Julian added a commit to Julian/lean.nvim that referenced this pull request Sep 27, 2025
@Julian
Add support for Lean 4.24's try this widget.
866d115 
Even though it's about to change again in leanprover/lean4#10524...
@mhuisi mhuisi force-pushed the mhuisi/show-term-regression branch from 6a4d939 to fd4e32e Compare October 1, 2025 15:17
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 1, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#10524
969fb38
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Oct 1, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#10524
d81357c
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 8, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#10524
d74a602
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Oct 8, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#10524
426dce9
mhuisi pushed a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Oct 11, 2025
@leanprover-community-mathlib4-bot @mhuisi
Update lean-toolchain for leanprover/lean4#10524
eab0683
@mhuisi mhuisi force-pushed the mhuisi/show-term-regression branch from 7c1d044 to 9c36329 Compare October 11, 2025 11:23
@leanprover-community-bot leanprover-community-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Oct 11, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 11, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#10524
34e5348
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Oct 11, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#10524
bfa5fa2
@mhuisi mhuisi added this pull request to the merge queue Oct 13, 2025
Merged via the queue into leanprover:master with commit 9d427fd Oct 13, 2025
25 checks passed
Julian added a commit to Julian/lean.nvim that referenced this pull request Oct 29, 2025
@Julian
Bump the Lean versions in CI.
f4c0888 
Refs: leanprover-community/import-graph#86
Refs: leanprover/lean4#10524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digama0 digama0 Awaiting requested review from digama0 digama0 is a code owner

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-server Language server, widgets, and IDE extensions toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mhuisi @leanprover-bot @leanprover-community-bot