-
Notifications
You must be signed in to change notification settings - Fork 715
feat: shake import minimizer aware of the module system and arbitrary elaboration dependencies
#10575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
!bench |
|
Here are the benchmark results for commit 74260e2. Benchmark Metric Change
=====================================================================
+ binarytrees.st maxrss -9.7% (-61.2 σ)
- bv_decide_rewriter.lean branches 1.9% (83.1 σ)
- bv_decide_rewriter.lean instructions 1.3% (41.1 σ)
- lake config elab instructions 2.5% (91.7 σ)
- libleanshared.so binary size 1.0%
- mut_rec_wf branches 1.9% (119.7 σ)
- mut_rec_wf instructions 1.2% (77.8 σ)
- stdlib attribute application 1.5% (50.2 σ)
- stdlib blocked (unaccounted) 12.3% (26.6 σ)
- stdlib grind ematch 4.2% (47.2 σ)
- stdlib process pre-definitions 1.3% (27.8 σ)
+ unionfind maxrss -7.2% (-178.9 σ) |
74260e2 to
bfe28ae
Compare
|
!bench |
|
Here are the benchmark results for commit bfe28ae. |
bfe28ae to
48a67f5
Compare
|
!bench |
|
Here are the benchmark results for commit 48a67f5. Benchmark Metric Change
=====================================================================
+ binarytrees.st maxrss -9.6% (-59.7 σ)
- bv_decide_inequality.lean maxrss 1.4% (20.6 σ)
- stdlib blocked (unaccounted) 12.8% (27.9 σ)
+ treemap.lean insertHit -1.2% (-60.7 σ)
+ unionfind maxrss -7.2% (-342.9 σ) |
|
Mathlib CI status (docs):
|
|
Reference manual CI status:
|
48a67f5 to
96abc1b
Compare
|
!bench |
|
Here are the benchmark results for commit 96abc1b. Benchmark Metric Change
==================================================================
- Init.Data.BitVec.Lemmas task-clock 4.7% (52.5 σ)
+ grind_ring_5.lean branch-misses -4.6% (-28.5 σ)
+ mut_rec_wf branch-misses -2.4% (-25.0 σ)
+ riscv-ast.lean branch-misses -2.6% (-55.0 σ)
- stdlib blocked (unaccounted) 13.7% (29.4 σ)
+ stdlib grind ac -4.3% (-36.4 σ) |
|
!bench |
|
Here are the benchmark results for commit e7d2354. Benchmark Metric Change
=============================================
+ stdlib type checking -1.6% (-134.5 σ) |
…ry elaboration dependencies (leanprover#10575) This PR adds the necessary infrastructure for recording elaboration dependencies that may not be apparent from the resulting environment such as notations and other metaprograms. An adapted version of `shake` from Mathlib is added to `script/` but may be moved to another location or repo in the future.
This PR adds the necessary infrastructure for recording elaboration dependencies that may not be apparent from the resulting environment such as notations and other metaprograms. An adapted version of
shakefrom Mathlib is added toscript/but may be moved to another location or repo in the future.