Skip to content

chore: use CMake build type in Lake core build #10581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tydeu merged 1 commit into from
Sep 27, 2025
Merged

chore: use CMake build type in Lake core build #10581

tydeu merged 1 commit into from
Sep 27, 2025

Conversation

@tydeu
Copy link
Member

@tydeu tydeu commented Sep 26, 2025

This PR alters the core build Lake configuration file to use the CMAKE_BUILD_TYPE for Lake's buildType.

@tydeu tydeu added the changelog-no Do not include this PR in the release changelog label Sep 26, 2025
@tydeu tydeu force-pushed the lakefile-cmake-build-type branch from 60d6414 to b93f826 Compare September 27, 2025 01:53
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 27, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Sep 27, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 5b8d4d72104e66de541339027b41b7e434c1ab7e --onto ac0b82933f6eac9914011ca2caf38d0e4e991160. You can force Mathlib CI using the force-mathlib-ci label. (2025-09-27 03:03:17)

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Sep 27, 2025

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 5b8d4d72104e66de541339027b41b7e434c1ab7e --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-09-27 03:03:18)

@tydeu tydeu added this pull request to the merge queue Sep 27, 2025
Merged via the queue into leanprover:master with commit b37d2ce Sep 27, 2025
16 checks passed
@tydeu tydeu deleted the lakefile-cmake-build-type branch September 27, 2025 03:57
@tydeu tydeu mentioned this pull request Sep 27, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 27, 2025
@tydeu
fix: only pass known CMake build types to Lake (#10595)
fbfc769 
This PR ensures that Lake only receives recognized CMake build types
from CMake. This fixes an issue with #10581 which broke the
`RelWithAssert` build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

changelog-no Do not include this PR in the release changelog toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tydeu @leanprover-community-bot @leanprover-bot