Skip to content

fix: non-LSP-compliant FileSystemWatcher #10609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhuisi merged 1 commit into from
Sep 29, 2025
Merged

fix: non-LSP-compliant FileSystemWatcher #10609

mhuisi merged 1 commit into from
Sep 29, 2025

Conversation

@mhuisi
Copy link
Contributor

@mhuisi mhuisi commented Sep 29, 2025 •
edited
Loading

This PR fixes an LSP-non-compliance in the FileSystemWatcher that was introduced in #925.

Closes #10597.

@mhuisi mhuisi added the changelog-server Language server, widgets, and IDE extensions label Sep 29, 2025
@mhuisi
Copy link
Contributor Author

mhuisi commented Sep 29, 2025

cc @Julian

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 29, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Sep 29, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 188ef680da2d093b76162907867b816cd9d4e110 --onto ac0b82933f6eac9914011ca2caf38d0e4e991160. You can force Mathlib CI using the force-mathlib-ci label. (2025-09-29 09:55:38)

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Sep 29, 2025

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 188ef680da2d093b76162907867b816cd9d4e110 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-09-29 09:55:40)

@mhuisi mhuisi added this pull request to the merge queue Sep 29, 2025
Merged via the queue into leanprover:master with commit c016bb9 Sep 29, 2025
21 of 23 checks passed
arthur-adjedj pushed a commit to arthur-adjedj/lean4 that referenced this pull request Oct 6, 2025
@mhuisi @arthur-adjedj
fix: non-LSP-compliant FileSystemWatcher (leanprover#10609)
b1b335c 
This PR fixes an LSP-non-compliance in the `FileSystemWatcher` that was
introduced in leanprover#925.

Closes leanprover#10597.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

changelog-server Language server, widgets, and IDE extensions toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FileSystemWatcher.kind serializes to non-fully-LSP-spec compliant JSON

3 participants

@mhuisi @leanprover-community-bot @leanprover-bot