Skip to content

feat: consistent type ABI regardless of transparency #10610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hargoniX merged 1 commit into from
Sep 29, 2025
Merged

feat: consistent type ABI regardless of transparency #10610

hargoniX merged 1 commit into from
Sep 29, 2025

Conversation

@hargoniX
Copy link
Contributor

@hargoniX hargoniX commented Sep 29, 2025

This PR ensures that even if a type is marked as irreducible the compiler can see through it in
order to discover functions hidden behind type aliases.

@hargoniX hargoniX added the changelog-compiler Compiler, runtime, and FFI label Sep 29, 2025
@hargoniX hargoniX force-pushed the hbv/compiler_type_transparency branch from f39ff10 to e5d58f9 Compare September 29, 2025 11:41
@hargoniX hargoniX force-pushed the hbv/compiler_type_transparency branch from e5d58f9 to 79ce9c6 Compare September 29, 2025 11:42
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 29, 2025
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Sep 29, 2025

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-09-24 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-09-29 13:24:27)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 29, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10610
68179cd
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Sep 29, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10610
234ae89
@hargoniX hargoniX added this pull request to the merge queue Sep 29, 2025
Merged via the queue into master with commit b82303e Sep 29, 2025
17 checks passed
@hargoniX hargoniX deleted the hbv/compiler_type_transparency branch September 29, 2025 14:16
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Sep 29, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Sep 29, 2025

Mathlib CI status (docs):

arthur-adjedj pushed a commit to arthur-adjedj/lean4 that referenced this pull request Oct 6, 2025
@hargoniX @arthur-adjedj
feat: consistent type ABI regardless of transparency (leanprover#10610)
29a2720 
This PR ensures that even if a type is marked as `irreducible` the
compiler can see through it in
order to discover functions hidden behind type aliases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

@zwarich zwarich Awaiting requested review from zwarich

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-compiler Compiler, runtime, and FFI toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hargoniX @leanprover-bot @leanprover-community-bot