fix: instantiate mvars in types of mvars in abstractMVars #10612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes an issue reported [on Zulip](https://leanprover.zulipchat.com/#narrow/channel/239415-metaprogramming-.2F-tactics/topic/.60abstractMVars.60.20not.20instantiating.20level.20mvars/near/541918246) where `abstractMVars` (which is used in typeclass inference and `simp` argument elaboration) was not instantiating metavariables in the types of metavariables, causing it to abstract already-assigned metavariables.
github-actions
bot
added
the
toolchain-available
Collaborator
|
Reference manual CI status:
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Sep 29, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Sep 29, 2025
leanprover-community-bot
added
the
builds-mathlib
Collaborator
|
Mathlib CI status (docs):
|
Collaborator
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit c208f29. |
arthur-adjedj
pushed a commit
to arthur-adjedj/lean4
that referenced
this pull request
Oct 6, 2025
…#10612) This PR fixes an issue reported [on Zulip](https://leanprover.zulipchat.com/#narrow/channel/239415-metaprogramming-.2F-tactics/topic/.60abstractMVars.60.20not.20instantiating.20level.20mvars/near/541918246) where `abstractMVars` (which is used in typeclass inference and `simp` argument elaboration) was not instantiating metavariables in the types of metavariables, causing it to abstract already-assigned metavariables. This also eliminates an unnecessary `instantiateMVars` and documents the invariant that the argument to `abstractExprMVars` must have its metavariables already instantiated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue reported on Zulip where
abstractMVars(which is used in typeclass inference andsimpargument elaboration) was not instantiating metavariables in the types of metavariables, causing it to abstract already-assigned metavariables.This also eliminates an unnecessary
instantiateMVarsand documents the invariant that the argument toabstractExprMVarsmust have its metavariables already instantiated.