Skip to content

fix: simp argument elaboration metacontext depth #10615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kmill wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: simp argument elaboration metacontext depth #10615

kmill wants to merge 2 commits into from

Conversation

@kmill
Copy link
Collaborator

@kmill kmill commented Sep 29, 2025

This PR fixes an issue where pre-existing metavariables in simp arguments would be abstracted, which could lead to type-incorrect terms. Closes #9286.

@kmill
fix: simp argument elaboration metacontext depth
b92da23 
This PR fixes an issue where pre-existing metavariables in simp arguments would be abstracted, which could lead to type-incorrect simp lemmas. Closes leanprover#9286.
@kmill kmill requested a review from kim-em as a code owner September 29, 2025 12:05
@kmill kmill added the changelog-tactics User facing tactics label Sep 29, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 29, 2025
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Sep 29, 2025

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-09-24 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-09-29 15:33:58)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 29, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10615
47df489
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Sep 29, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#10615
27f73b3
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Sep 29, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Sep 29, 2025

Mathlib CI status (docs):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees

No one assigned

Labels

breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan changelog-tactics User facing tactics toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

simp abstracts too many meta-variables

3 participants

@kmill @leanprover-bot @leanprover-community-bot