Skip to content

chore: use libPrefixOnWindows in core build #10617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tydeu merged 1 commit into from
Sep 29, 2025
Merged

chore: use libPrefixOnWindows in core build #10617

tydeu merged 1 commit into from
Sep 29, 2025

Conversation

@tydeu
Copy link
Member

@tydeu tydeu commented Sep 29, 2025

This PR switches the core build Lake configuration file to use libPrefixOnWindows rather than a CMake hack.

It also removes some dead TOML variables from the CMake configuration.

@tydeu tydeu added release-ci Enable all CI checks for a PR, like is done for releases changelog-no Do not include this PR in the release changelog labels Sep 29, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 29, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Sep 29, 2025

Mathlib CI status (docs):

  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2025-09-28 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. You can force Mathlib CI using the force-mathlib-ci label. (2025-09-29 15:41:10)

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Sep 29, 2025

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-09-28 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-09-29 15:41:12)

@tydeu tydeu added this pull request to the merge queue Sep 29, 2025
Merged via the queue into leanprover:master with commit 5ede2bf Sep 29, 2025
32 of 36 checks passed
@tydeu tydeu deleted the lakefile-libPrefixOnWindows branch September 30, 2025 00:51
arthur-adjedj pushed a commit to arthur-adjedj/lean4 that referenced this pull request Oct 6, 2025
@tydeu @arthur-adjedj
chore: use libPrefixOnWindows in core build (leanprover#10617)
420d774 
This PR switches the core build Lake configuration file to use
`libPrefixOnWindows` rather than a CMake hack.

It also removes some dead TOML variables from the CMake configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

changelog-no Do not include this PR in the release changelog release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tydeu @leanprover-community-bot @leanprover-bot