Skip to content

fix: unknown identifier code actions with nested open #10619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhuisi merged 1 commit into from
Sep 29, 2025
Merged

fix: unknown identifier code actions with nested open #10619

mhuisi merged 1 commit into from
Sep 29, 2025

Conversation

@mhuisi
Copy link
Contributor

@mhuisi mhuisi commented Sep 29, 2025

This PR fixes a bug in the unknown identifier code actions where it would yield non-sensical suggestions for nested open declarations like open Foo.Bar.

@mhuisi mhuisi added the changelog-server Language server, widgets, and IDE extensions label Sep 29, 2025
@mhuisi mhuisi added this pull request to the merge queue Sep 29, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 29, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Sep 29, 2025

Mathlib CI status (docs):

  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2025-09-29 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. You can force Mathlib CI using the force-mathlib-ci label. (2025-09-29 15:58:17)

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Sep 29, 2025

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-09-29 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-09-29 15:58:19)

Merged via the queue into leanprover:master with commit 9f2ce63 Sep 29, 2025
21 checks passed
arthur-adjedj pushed a commit to arthur-adjedj/lean4 that referenced this pull request Oct 6, 2025
@mhuisi @arthur-adjedj
fix: unknown identifier code actions with nested open (leanprover#1…
e15edbb 
…0619)

This PR fixes a bug in the unknown identifier code actions where it
would yield non-sensical suggestions for nested `open` declarations like
`open Foo.Bar`.
@mhuisi mhuisi mentioned this pull request Oct 15, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 15, 2025
@mhuisi
fix: unknown identifier minimization (#10797)
4329eae 
This PR fixes a bug in the unknown identifier code actions where the
identifiers wouldn't be correctly minimized in nested namespaces. It
also fixes a bug where identifiers would sometimes be minimized to
`[anonymous]`.

The first bug was introduced in #10619.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

changelog-server Language server, widgets, and IDE extensions toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mhuisi @leanprover-community-bot @leanprover-bot