-
Notifications
You must be signed in to change notification settings - Fork 715
refactor: tame down dead let eliminator in lambda RC #10626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+24
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
655ba98 to
37a8ad7
Compare
37a8ad7 to
51d6173
Compare
51d6173 to
545fff9
Compare
Contributor
Author
|
!bench |
Collaborator
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Collaborator
|
Here are the benchmark results for commit 545fff9. Benchmark Metric Change
============================================
- stdlib grind linarith 19.1% (26.0 σ) |
Rob23oba
reviewed
Sep 30, 2025
545fff9 to
731bbb5
Compare
arthur-adjedj
pushed a commit
to arthur-adjedj/lean4
that referenced
this pull request
Oct 6, 2025
This PR reduces the aggressiveness of the dead let eliminator from lambda RC. The motivation for this is that all other passes in lambda RC respect impurity but the dead let eliminator still operates under the assumption of purity. There is a couple of motivations for the elim dead let elaborator: - unused projections introduced by the ToIR translation - the elim dead branch pass introducing new opportunities - closed term extraction introducing new opportunities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog-compiler
Compiler, runtime, and FFI
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the aggressiveness of the dead let eliminator from lambda RC.
The motivation for this is that all other passes in lambda RC respect impurity but the dead let eliminator still operates under the assumption of purity. There is a couple of motivations for the elim dead let elaborator: