-
Notifications
You must be signed in to change notification settings - Fork 717
feat: add forall_fin_zero and exists_fin_zero #10627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Mathlib CI status (docs):
|
|
Reference manual CI status:
|
|
this needs benchmarking, I think the reason it doesn't exist is because it has a too-generic discrimination tree key |
|
I'd be happy to see a benchmark but this suggests it's not too generic: See also the RFC discussion #10629 |
|
!bench |
|
Benchmark results for 107bef7 against dfd3d18 are in! @TwoFX |
|
Here are the benchmark results for commit 107bef7. Benchmark Metric Change
==========================================================
+ stdlib let-to-have transformation -2.0% (-32.8 σ)
+ stdlib process pre-definitions -3.3% (-118.8 σ) |
|
@fgdorais, this PR looks fine to me but it's still a draft, is it still waiting for something? |
|
The RFC hasn't been approved. |
This PR adds lemmas
forall_fin_zeroandexists_fin_zero. It also marks lemmasforall_fin_zero,forall_fin_one,forall_fin_two,exists_fin_zero,exists_fin_one,exists_fin_twowithsimpattribute.Closes #10629