Skip to content

Conversation

@ydewit
Copy link
Contributor

@ydewit ydewit commented Sep 30, 2025

This PR fixes a broken link to the firefox profile definitions in one of the comments.

The profile.js file was renamed to profile.ts while the rest of the url remained the same.

Copilot AI review requested due to automatic review settings September 30, 2025 19:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates a comment to reflect that the Firefox profiler source file has been renamed from profile.js to profile.ts, correcting the reference link in the code documentation.

  • Updated source file reference from profile.js to profile.ts

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ydewit ydewit changed the title Update comment to reflect new profile.js source link Update comment to reflect new profile.ts source link Sep 30, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 30, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase dfd3d185300df044fa087d3fa166cb6fb3bd8269 --onto 7d55c033e1f0ad8cb7c2b9ab72e5db40ce192222. You can force Mathlib CI using the force-mathlib-ci label. (2025-09-30 19:56:49)

@leanprover-bot
Copy link
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase dfd3d185300df044fa087d3fa166cb6fb3bd8269 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-09-30 19:56:51)

@nomeata
Copy link
Collaborator

nomeata commented Sep 30, 2025

Please follow the contribution guidelines, in particular with regard to PR title and description.

@ydewit ydewit changed the title Update comment to reflect new profile.ts source link fix: fixed url to profile.ts source Oct 1, 2025
@ydewit ydewit marked this pull request as draft October 1, 2025 02:47
@ydewit ydewit marked this pull request as ready for review October 1, 2025 02:51
@ydewit ydewit changed the title fix: fixed url to profile.ts source doc: fixed url to profile.ts source Oct 1, 2025
@Kha Kha changed the title doc: fixed url to profile.ts source doc: fix url to profile.ts source Oct 7, 2025
@Kha Kha enabled auto-merge October 7, 2025 12:40
@Kha Kha added this pull request to the merge queue Oct 7, 2025
Merged via the queue into leanprover:master with commit 5c92ffc Oct 7, 2025
25 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants